Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 560238

Summary: RenameResourceHandler asks for new name twice in Project Explorer.
Product: [Eclipse Project] JDT Reporter: Christian Dietrich <christian.dietrich.opensource>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: CLOSED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: loskutov
Version: 4.14   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=560091
https://bugs.eclipse.org/bugs/show_bug.cgi?id=560113
Whiteboard:
Attachments:
Description Flags
Gif showing the Problem none

Description Christian Dietrich CLA 2020-02-17 09:51:40 EST 
If you rename a Xtend file in Project Explorer then the user will be asked for the new name twice.
once inline, once via dialog.

org.eclipse.ltk.internal.ui.refactoring.actions.RenameResourceHandler.performRename(ExecutionEvent)
will open a RefactoringWizardOpenOperation due the change is a composite change.

the comment say

// Let user see rename dialog with preview page for composite changes or if another RefactoringProcessor is used (which may offer rename options)
					
=> shouldnt the dialog just show the preview and not ask for the new name twice?
=> if this is intended, how can this behaviour be avoided?
Comment 1 Christian Dietrich CLA 2020-02-17 09:55:40 EST 
Created attachment 281840 [details]
Gif showing the Problem
Comment 2 Andrey Loskutov CLA 2020-02-17 10:01:21 EST 
Is this a duplicate of bug 560113?
Comment 3 Christian Dietrich CLA 2020-02-17 10:02:05 EST 
yes. didnt see that one
Comment 4 Andrey Loskutov CLA 2020-02-17 10:03:05 EST 

*** This bug has been marked as a duplicate of bug 560113 ***