Bugzilla – Full Text Bug Listing
| Summary: | Update close button on tab to something nicer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||
| Component: | SWT | Assignee: | Platform-SWT-Inbox <platform-swt-inbox> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | Lars.Vogel, ma.becker | ||||
| Version: | 4.14 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Matthias, what do you think? Would you be able to help with a new icon? We have close button icon. I have used it in https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=d5142ba754dc34181e6a4939a5629b821a8e0d2e . Why not use this one? (In reply to Alexander Kurtakov from comment #2) > We have close button icon. I have used it in > https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/ > ?id=d5142ba754dc34181e6a4939a5629b821a8e0d2e . Why not use this one? Makes sense to use the same icon. But eclipse.platform.ua/org.eclipse.help.ui/icons/elcl16/close.png seems to use only dark, which would not fix the dark theme. The icon of VScode seems usable in both ligth and dark theme. Microsoft icon repo: https://github.com/microsoft/vscode-icons (In reply to Lars Vogel from comment #3) > (In reply to Alexander Kurtakov from comment #2) > > We have close button icon. I have used it in > > https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/ > > ?id=d5142ba754dc34181e6a4939a5629b821a8e0d2e . Why not use this one? > > Makes sense to use the same icon. But > eclipse.platform.ua/org.eclipse.help.ui/icons/elcl16/close.png seems to use > only dark, which would not fix the dark theme. The icon of VScode seems > usable in both ligth and dark theme. As far as I see they use different SVGs on light and dark theme. *** This bug has been marked as a duplicate of bug 501491 *** |
Created attachment 281817 [details] Screenshot The software drawn close button in Eclipse does not look good compared to other editors as for example code. This is especially true for low resolutions. Also the close button on the tab is not consistent with the close button for the Eclipes application. I suggest we adapt a similar button as VsCode to look better and more consistent. This will also allow us to leverage the research for the UI designers at Microsoft.