Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 559705

Summary:

[Cocoa] [Regression] Arrows in breadcrumb view have white background

Product:

[Eclipse Project] Platform

Reporter:

Lakshmi P Shanmugam <lshanmug>

Component:

SWT

Assignee:

Sravan Kumar Lakkimsetti <sravankumarl>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

4.15

Target Milestone:

4.15 M3

Hardware:

OS:

Mac OS X

See Also:

https://git.eclipse.org/r/157494
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=7afefd0a269900dca511e16bdb0f037877efc22c

Whiteboard:

Attachments:

Description	Flags
screenshot	none

Description Lakshmi P Shanmugam

2020-01-30 07:18:24 EST

Created attachment 281651 [details]
screenshot

I20200129-1800
mac 10.15

Arrows in breadcrumb view have white foreground/background. The black triangle is hardly visible.
See attached screenshot.

Seems to be happening after Bug 310387.

Comment 1 Lakshmi P Shanmugam

2020-01-30 07:21:51 EST

Sravan, please investigate.

Comment 2 Sravan Kumar Lakkimsetti

2020-02-03 02:51:00 EST

Does this happen in non retina mode?

Comment 3 Lakshmi P Shanmugam

2020-02-04 02:07:49 EST

(In reply to Sravan Kumar Lakkimsetti from comment #2)
> Does this happen in non retina mode?

I've not tried.

Comment 4 Eclipse Genie

2020-02-11 07:44:14 EST

New Gerrit change created: https://git.eclipse.org/r/157494

Comment 5 Eclipse Genie

2020-02-11 07:46:26 EST

Gerrit change https://git.eclipse.org/r/157494 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=7afefd0a269900dca511e16bdb0f037877efc22c

Comment 6 Sravan Kumar Lakkimsetti

2020-02-12 01:26:55 EST

My investigation indicates this problem is a regression from Bug 508491. Though https://git.eclipse.org/r/157494 fixes this particular issue, I am not comfortable with the fix done for Bug 508491. Many of the regressions are getting uncovered because of hi-dpi change.

Apart from this bug Bug 310387(specifically problem with black background in second and third columns) is a regression from bug 508491.

Comment 7 Lakshmi P Shanmugam

2020-03-13 03:52:23 EDT

(In reply to Sravan Kumar Lakkimsetti from comment #6)

Took sometime to investigate and respond as I was occupied with 4.15 stuff.

> My investigation indicates this problem is a regression from Bug 508491.
Please explain how.

> Though https://git.eclipse.org/r/157494 fixes this particular issue, I am
> not comfortable with the fix done for Bug 508491. Many of the regressions are >getting uncovered because of hi-dpi change.
Bug 508491 added new approach to create alpha information for 100 and 200% representations when required, it was fixed in 4.7 and didn't cause problems until 4.12 when Bug 489451 was fixed. Since there were no problems before, there was nothing more to fix in Bug 508491. The right approach to be taken was to test different cases when fixing Bug 489451 and make sure nothing was broken.
That said, feel free to provide an alternate fix for Bug 508491.

> Apart from this bug Bug 310387(specifically problem with black background in
> second and third columns) is a regression from bug 508491.
To summarize, looking at the fix made in this bug (code added by Bug 310387 was removed), it is clearly a regression from Bug 310387 and Bug 310387(not the original bug, but specifically the problem with black background in second and third columns) is a regression from Bug 489451.