Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 559224

Summary:	Add junit 4.13
Product:	[Tools] Orbit	Reporter:	Matthias Sohn <matthias.sohn>
Component:	bundles	Assignee:	Orbit Bundles <orbit.bundles-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	thatnitind
Version:	unspecified
Target Milestone:	2020-03 M2
Hardware:	PC
OS:	Mac OS X
See Also:	https://git.eclipse.org/r/156053 https://git.eclipse.org/r/156220 https://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=3c9aab0bfa84d44bcd4f73297d13b9538ed615fc https://git.eclipse.org/r/156400 https://bugs.eclipse.org/bugs/show_bug.cgi?id=558857 https://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=8a4df85dede958744c8084ed571c77e7a99bb875 https://git.eclipse.org/r/156713 https://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=76399b34d900a34dbabbc50ecf601c85b80d2a27 https://git.eclipse.org/r/157146 https://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=1c69bc41f065c1eacafa7cf6d33166a5d437a8d3
Whiteboard:
Bug Depends on:
Bug Blocks:	558857

Description Matthias Sohn

2020-01-15 18:48:15 EST

We want to update to junit 4.13 for JGit.

Filed CQ
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=21440
for adding it to Orbit.

Comment 1 Eclipse Genie

2020-01-17 03:37:33 EST

New Gerrit change created: https://git.eclipse.org/r/156053

Comment 2 Eclipse Genie

2020-01-20 14:27:34 EST

New Gerrit change created: https://git.eclipse.org/r/156220

Comment 3 Eclipse Genie

2020-01-20 16:12:57 EST

Gerrit change https://git.eclipse.org/r/156053 was merged to [master].
Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=3c9aab0bfa84d44bcd4f73297d13b9538ed615fc

Comment 4 Nitin Dahyabhai

2020-01-22 18:16:32 EST

I think this might have caused the webtools.sourceediting builds to start failing with:

Error Message
org/hamcrest/SelfDescribing
Stacktrace
java.lang.NoClassDefFoundError: org/hamcrest/SelfDescribing
Caused by: java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing cannot be found by org.junit_4.13.0.v20200120-1926

(8 others as well at https://ci.eclipse.org/webtools/job/webtools-sourceediting_master/lastCompletedBuild/testReport/)

org.junit 4.12's manifest required and reexported the org.hamcrest.core bundle while the new recipe imports its packages as optional, and doesn't reexport them. What's confusing is that the same error message keeps occurring even though my test bundle now explicitly requires org.hamcrest.core itself.

Comment 5 Eclipse Genie

2020-01-23 04:48:00 EST

New Gerrit change created: https://git.eclipse.org/r/156400

Comment 6 Matthias Sohn

2020-01-23 04:59:52 EST

(In reply to Nitin Dahyabhai from comment #4)
> I think this might have caused the webtools.sourceediting builds to start
> failing with:
> 
> Error Message
> org/hamcrest/SelfDescribing
> Stacktrace
> java.lang.NoClassDefFoundError: org/hamcrest/SelfDescribing
> Caused by: java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing
> cannot be found by org.junit_4.13.0.v20200120-1926
> 
> (8 others as well at
> https://ci.eclipse.org/webtools/job/webtools-sourceediting_master/
> lastCompletedBuild/testReport/)
> 
> org.junit 4.12's manifest required and reexported the org.hamcrest.core
> bundle while the new recipe imports its packages as optional, and doesn't
> reexport them. What's confusing is that the same error message keeps
> occurring even though my test bundle now explicitly requires
> org.hamcrest.core itself.

please review https://git.eclipse.org/r/#/c/156400/

Comment 7 Matthias Sohn

2020-01-26 15:28:00 EST

(In reply to Matthias Sohn from comment #6)
> (In reply to Nitin Dahyabhai from comment #4)
> > I think this might have caused the webtools.sourceediting builds to start
> > failing with:
> > 
> > Error Message
> > org/hamcrest/SelfDescribing
> > Stacktrace
> > java.lang.NoClassDefFoundError: org/hamcrest/SelfDescribing
> > Caused by: java.lang.ClassNotFoundException: org.hamcrest.SelfDescribing
> > cannot be found by org.junit_4.13.0.v20200120-1926
> > 
> > (8 others as well at
> > https://ci.eclipse.org/webtools/job/webtools-sourceediting_master/
> > lastCompletedBuild/testReport/)
> > 
> > org.junit 4.12's manifest required and reexported the org.hamcrest.core
> > bundle while the new recipe imports its packages as optional, and doesn't
> > reexport them. What's confusing is that the same error message keeps
> > occurring even though my test bundle now explicitly requires
> > org.hamcrest.core itself.
> 
> please review https://git.eclipse.org/r/#/c/156400/

updated https://git.eclipse.org/r/#/c/156400/ 
to use Require-Bundle and reexport hamcrest.core 1.3

Comment 8 Eclipse Genie

2020-01-26 18:16:18 EST

Gerrit change https://git.eclipse.org/r/156400 was merged to [master].
Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=8a4df85dede958744c8084ed571c77e7a99bb875

Comment 9 Nitin Dahyabhai

2020-01-27 08:22:37 EST

My builds are green again. Thanks, Matthias!

Comment 10 Eclipse Genie

2020-01-28 08:49:52 EST

Gerrit change https://git.eclipse.org/r/156713 was merged to [master].
Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=76399b34d900a34dbabbc50ecf601c85b80d2a27

Comment 11 Eclipse Genie

2020-02-04 10:01:32 EST

New Gerrit change created: https://git.eclipse.org/r/157146

Comment 12 Eclipse Genie

2020-02-04 11:00:50 EST

Gerrit change https://git.eclipse.org/r/157146 was merged to [master].
Commit: http://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=1c69bc41f065c1eacafa7cf6d33166a5d437a8d3