Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 558888

Summary:	Unable to push changes to the m2e gerrit
Product:	Community	Reporter:	Mat Booth <mat.booth>
Component:	Gerrit	Assignee:	Eclipse Webmaster <webmaster>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Mat Booth

2020-01-07 10:03:42 EST

Here's what I see when I attempt to push a change to the m2e gerrit:

[mbooth@thinkpad-p50 m2e-core]$ git push review 
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 8 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (5/5), 730 bytes | 365.00 KiB/s, done.
Total 5 (delta 3), reused 0 (delta 0)
remote: Resolving deltas: 100% (3/3)
remote: Processing changes: refs: 1, done    
remote: ----------
remote: Reviewing commit: 805a3ff2
remote: Authored by: Mat Booth <mat.booth@redhat.com>
remote: 
remote: The author is not a committer on the project.
remote: error: The author does not have a current Eclipse Contributor Agreement (ECA) on file.
remote: If there are multiple commits, please ensure that each author has a ECA.
remote: 
remote: The author has "signed-off" on the contribution.
remote: Please see http://wiki.eclipse.org/ECA
To ssh://git.eclipse.org:29418/m2e/m2e-core.git
 ! [remote rejected]   HEAD -> refs/for/master (An Eclipse Contributor Agreement is required.)
error: failed to push some refs to 'ssh://mboothao6@git.eclipse.org:29418/m2e/m2e-core.git'


But I *do* in fact have a valid ECA under the author email mat.booth@redhat.com -- it does not expire until 2023. I tried re-signing it anyway, but I still observe the same behaviour.

And I don't think the problem is on my end because I am fully able to push and merge changes for other projects. I.e.: I was just able to push this change just now to test my git config: https://git.eclipse.org/r/#/c/155403/


Any ideas what can be wrong here?

Comment 1 Mat Booth

2020-01-07 10:15:09 EST

FWIW, yes "mboothao6" genuinely is (and always has been) my gerrit username. Don't ask me why -- I always assumed that perhaps the username "mbooth" was already taken and gerrit just added some random noise at the end to make me unique.

Comment 2 Eclipse Webmaster

2020-01-07 10:38:24 EST

No, it looks like that was an older account of yours(or someone else named Mat Booth), and the CLA on file for that account expired in 2015.

I think that Gerrit is 'translating' user permissions when you push with that id.  Gerrit knows how to map people in our back end permissions store and is using those permissions for projects where where you are a committer, but when you push to a project that you don't commit to it's passing the 'bad' id to the ECA checker which is then failing.

I've updated the Gerrit DB to use your actual committer id(mbooth), so please update the Git URL and try again.  We may need to wait for the Gerrit re-indexer to run in an hour or so just to clean up it's cache.

-M.

Comment 3 Mat Booth

2020-01-07 11:42:54 EST

> I've updated the Gerrit DB to use your actual committer id(mbooth), so please
> update the Git URL and try again. 

It's an hour later and in gerrit -> settings I still see my user id as "mboothao6" .. when you say update the git url, to what are you suggesting I change it?

Comment 4 Mat Booth

2020-01-07 12:02:57 EST

(In reply to Mat Booth from comment #3)
> > I've updated the Gerrit DB to use your actual committer id(mbooth), so please
> > update the Git URL and try again. 
> 
> It's an hour later and in gerrit -> settings I still see my user id as
> "mboothao6" .. when you say update the git url, to what are you suggesting I
> change it?

Aha, I tried logging out and back in and the user id had changed. I can now push to the m2e gerrit: https://git.eclipse.org/r/#/c/155415/

Thanks for the quick fix