Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 558875

Summary: [JUnit 5] Add JUnit 5.6 bundles to Orbit
Product: [Tools] Orbit Reporter: Noopur Gupta <noopur_gupta>
Component: bundlesAssignee: Roland Grunberg <rgrunber>
Status: RESOLVED FIXED QA Contact: Roland Grunberg <rgrunber>
Severity: enhancement    
Priority: P3 CC: akurtakov, christian.dietrich.opensource, daniel_megert, loskutov, rgrunber
Version: unspecified   
Target Milestone: 2020-03 M3   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/156762
https://git.eclipse.org/c/orbit/orbit-recipes.git/commit/?id=d0315aa4867bc82a89b6c548b49ff2a1aee2442e
Whiteboard:
Bug Depends on:    
Bug Blocks: 558873    

Description Noopur Gupta CLA 2020-01-07 05:43:27 EST
We should replace JUnit 5.5.1 JARs with JUnit 5.6 JARs when it is released.
https://github.com/junit-team/junit5/milestones
Comment 1 Noopur Gupta CLA 2020-01-07 05:47:58 EST
Roland, can you please handle this?

We should remember to rename about_files to about-files for JUnit 5.6 JARs - see bug 550376 comment #16.
Comment 2 Noopur Gupta CLA 2020-01-21 05:22:12 EST
JUnit 5.6 has been released:
https://junit.org/junit5/docs/current/release-notes/index.html#release-notes-5.6.0
Comment 3 Roland Grunberg CLA 2020-01-28 09:48:06 EST
Is there any opposition to this missing Orbit M2, and instead making M3 ? I can do it early in the M3 cycle but I haven't had a chance to look at this yet.
Comment 4 Noopur Gupta CLA 2020-01-28 11:12:46 EST
(In reply to Roland Grunberg from comment #3)
> Is there any opposition to this missing Orbit M2, and instead making M3 ? I
> can do it early in the M3 cycle but I haven't had a chance to look at this
> yet.

OK for me. Please update the target milestone if there are no other objections.
Comment 5 Roland Grunberg CLA 2020-01-28 12:07:36 EST
Dani mentioned wanting to aim for M2 by end of week.

So running https://bugs.eclipse.org/bugs/show_bug.cgi?id=543822#c3 , it looks like the main change seems to be JUnit 4.12 -> 4.13, which I've bumped in the osgi.bnd files.

I'll just need to file the CQs now.
Comment 6 Eclipse Genie CLA 2020-01-28 13:10:56 EST
New Gerrit change created: https://git.eclipse.org/r/156762
Comment 8 Andrey Loskutov CLA 2020-02-05 12:57:38 EST
Looks like this csn be closed now? Orbit has 5.6.0.
Comment 9 Noopur Gupta CLA 2020-02-07 04:13:36 EST
(In reply to Andrey Loskutov from comment #8)
> Looks like this csn be closed now? Orbit has 5.6.0.

Yes, closing the bug.