Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 55581

Summary:	[KeyBindings] pressing Ctrl-F6 again closes editor list
Product:	[Eclipse Project] Platform	Reporter:	Rafael Chaves <eclipse>
Component:	UI	Assignee:	Douglas Pollock <douglas.pollock>
Status:	VERIFIED FIXED	QA Contact:
Severity:	critical
Priority:	P1	CC:	dirk_baeumer, markus.kell.r, matt, n.a.edgar, pascal, Tod_Creasey, travis.hume
Version:	3.0
Target Milestone:	3.0 M8
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Rafael Chaves

2004-03-22 14:58:39 EST

i20040322

Pressing Ctrl-F6 opens a list of open editors for easily switching between them.
With this build, after the list is appearing, pressing Ctrl-F6 again closes it
(it used to traverse the list of editors).

Comment 1 Rafael Chaves

2004-03-22 14:59:10 EST

Setting milestone as requested.

Comment 2 Douglas Pollock

2004-03-23 10:10:06 EST

*** Bug 55659 has been marked as a duplicate of this bug. ***

Comment 3 Douglas Pollock

2004-03-23 10:10:36 EST

*** Bug 55634 has been marked as a duplicate of this bug. ***

Comment 4 Travis Hume

2004-03-23 19:19:53 EST

Additionally and maybe related

After the second keypress, the window is dismissed and often keybinding will not
work again until a different view in focused using the mouse.

Comment 5 Douglas Pollock

2004-03-24 11:51:05 EST

*** Bug 55890 has been marked as a duplicate of this bug. ***

Comment 6 Douglas Pollock

2004-03-24 13:07:37 EST

Sorry to do the duplicate to a more recent bug, but the more recent bug has a 
more succinct description of the real problem.  (Ironically, the more recent 
bug has discovered while trying to fix this bug.) 

*** This bug has been marked as a duplicate of 55951 ***

Comment 7 Markus Keller

2004-03-25 05:51:27 EST

Still doesn't work in 20040325-0010.
Also doesn't work if I set "When" to "In Dialogs and Windows".

Comment 8 Douglas Pollock

2004-03-25 09:47:18 EST

Sorry, we'd tested this on Mike's machine and it had appeared to work.  Testing 
again on my machine it doesn't. 
 
I believe I've figured out why.  The opening of the cycle part dialog triggers 
a context switch, which invalidates the key bindings.  Every time a key is 
pressed, the dialog queries for the keys associated with its action.  This 
means it loses track of the appropriate key binding as the context switch 
invalidates its own key binding.  It also happens to be inefficient to keep 
querying.

Comment 9 Douglas Pollock

2004-03-25 10:02:17 EST

Fixed in CVS.  The key binding is cached before the dialog is open.  Other 
possible solutions: 
+ Change the dialog to be treated as a window 
+ Define a context for the dialog containing its key bindings 
+ Extend the command manager interface to provide key binding definitions 
rather than just the current key bindings (see Bug 46662)

Comment 10 Douglas Pollock

2004-03-25 17:14:34 EST

Verified in I200403251200 by opening two editors and using "Ctrl+F6" and 
"Ctrl+Shift+F6" multiple times and then releasing "Ctrl".

Comment 11 Nick Edgar

2004-04-08 17:10:10 EDT

*** Bug 55548 has been marked as a duplicate of this bug. ***