Bugzilla – Full Text Bug Listing
| Summary: | [GTK] Checkbox hard to see on active part | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||||
| Component: | SWT | Assignee: | Paul Pazderski <paul-eclipse> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | akurtakov, Lars.Vogel, paul-eclipse, sravankumarl | ||||||
| Version: | 4.14 | ||||||||
| Target Milestone: | 4.15 M3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=546552 https://git.eclipse.org/r/155614 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9ccf91807434740451f65dd6f4fe1ed15ecdcb72 |
||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 553537 | ||||||||
| Attachments: |
|
||||||||
I see the issue on my machine too but in order to debug it I would need someone to provide a pure SWT snippet for debuggin purposes - there are just way too many layers there to lose time with this one. Especially considering checkboxes in all other places I've seen work just fine. Created attachment 281446 [details]
Checkbox in composite with background inheritance before and after change.
I would guess writing a snippet is 90% of the fix and to prove myself I actually did it.
My result is that writing a snippet is even 120% of the work for me. I came faster to a possible fix than to the working snippet.
I attached the result before and after fix. Snippet is part my of proposed change.
I reported this issue a while back in another related bug (was not the same and is closed meanwhile) for Job Factory view and SWT Controls Example View. Both are fixed with this change.
The problem was that the checkbox inherited the light background from the parent composite.
New Gerrit change created: https://git.eclipse.org/r/155614 (In reply to Paul Pazderski from comment #2) > Created attachment 281446 [details] > Checkbox in composite with background inheritance before and after change. > > I would guess writing a snippet is 90% of the fix and to prove myself I > actually did it. > > My result is that writing a snippet is even 120% of the work for me. I came > faster to a possible fix than to the working snippet. haha, I can imagine that. There is a reason why I hate all generated UIs going through tens of layeres :). > > I attached the result before and after fix. Snippet is part my of proposed > change. > > I reported this issue a while back in another related bug (was not the same > and is closed meanwhile) for Job Factory view and SWT Controls Example View. > Both are fixed with this change. > The problem was that the checkbox inherited the light background from the > parent composite. Thanks for working on it! (In reply to Alexander Kurtakov from comment #4) > (In reply to Paul Pazderski from comment #2) > > Created attachment 281446 [details] > > Checkbox in composite with background inheritance before and after change. > > > > I would guess writing a snippet is 90% of the fix and to prove myself I > > actually did it. > > > > My result is that writing a snippet is even 120% of the work for me. I came > > faster to a possible fix than to the working snippet. > > There is a reason why I hate all generated UIs going through tens of layeres :). Me too. Shortcuts/commands/handlers are my personal nightmare of too much layers. And of cause my comment was not meant mean (it is possible to read it this way). I had a hunch, tried it and was luckily right. Thanks Alex and Paul for looking into this issue. Gerrit change https://git.eclipse.org/r/155614 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9ccf91807434740451f65dd6f4fe1ed15ecdcb72 Thanks Paul. Really appreciated ! verified in Eclipse SDK Version: 2020-03 (4.15) Build id: I20200217-1800 OS: Linux, v.4.12.14-lp151.28.36-default, x86_64 / gtk 3.22.30, WebKit 2.26.2 Java version: 1.8.0_232 |
Created attachment 280830 [details] Screencast See in the attached video. Tested with Ubuntu 19.10 and Eclipse SDK Version: 2019-12 (4.14) Build id: I20191127-1800 OS: Linux, v.5.3.0-23-generic, x86_64 / gtk 3.24.12 Java version: 12.0.1 To test: Install e4 spies and start model spy. Open a part and check the checkbox on it.