Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 553575

Summary: DOT Editor - Add content assist support to dot html-like label color attribute values.
Product: [Tools] GEF Reporter: Tamas Miklossy <miklossy>
Component: GEF DOTAssignee: Zoey Gerrit Prigge <eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 5.3.0 (2019-12)   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Screenshot about the current color content assistant support none

Description Tamas Miklossy CLA 2019-11-28 06:21:41 EST
Created attachment 280809 [details]
Screenshot about the current color content assistant support

Given is the following dot graph:

graph {
	
	1 [label=<
		<FONT COLOR="black" >text</FONT>
	>]
	
	2 [color=]
}

The DOT Editor already provides content assistant support on dot color attribute values (see also the attached screenshot).

This support should be extended to dot html-like label color attribute values.
Comment 1 Zoey Gerrit Prigge CLA 2020-01-09 04:48:15 EST
I pushed a commit with the following requested changes to the master branch:

[553575] Implement Html Color Attribute content assist

- Make DotColorProposalProvider aware of Color Scheme for Html-like
label attribute ca
- Include case for color/bgcolor attributes in
DotHtmlLabelProposalProvider making use of DotProposalProviderDelegator
and DotColor grammar
- Move expected CA arrays from DotContentAssistTest to DotTestUtils for
reuse
- Implement corresponding DotContentAssist2Test and
DotHtmlLabelContentAssistTest test cases


The html like label also allows for the BGCOLOR attribute which has an additional option of specifying a gradient using ":".

This will be implemented in a further commit.
Comment 2 Zoey Gerrit Prigge CLA 2020-01-30 15:41:08 EST
Thank you, Tamas, for merging my pull request 83 with the following changes:

[553575] Dot Editor: Html-Like Label BGColor Attribute CA support

-Implement support for CA with the gradient colon separated bgcolor
format in DotHtmlProposalProvider
-Change the prefix based use of DotProposalProviderDelegator to use of
current node if possible
-Implement corresponding DotHtmlContentAssistTests
my


Closing as resolved fixed in 5.4.0 (2020-03).