Bugzilla – Full Text Bug Listing
| Summary: | [workspace] generated build script should use preference setting for source and target | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Sebastian Davids <sdavids> |
| Component: | Build | Assignee: | Andrew Niefer <aniefer> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | chris, emissary, frederic, wassim.melhem |
| Version: | 3.0 | ||
| Target Milestone: | 3.2 M4 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Sebastian Davids
Yes, but when PDE creates the ant launch configuration for you, we override these values in the config using the ones specified on the pref page. Also, when we export, we use the values on the pref page to override the ones in the script. Moving to PDE/Build to close or continue this discussion. Keep open as an enhancement. *** Bug 49338 has been marked as a duplicate of this bug. *** Clements Drews have located the two lines of code making the trouble since ... the 13th october 2003: see http://dev.eclipse.org/newslists/news.eclipse.platform/msg07878.html " OK, did a little more research... I guess the culprit is in org.eclipse.pde.internal.build.builder.ModelBuildScriptGenerator ---- 449: script.printProperty(PROPERTY_JAVAC_SOURCE, "1.4"); //$NON-NLS-1$ 450: script.printProperty(PROPERTY_JAVAC_TARGET, "1.4"); //$NON-NLS-1$ --- Is this worth filing a bug report? - Clemens " So, why is it so difficult to resolve once and for all this issue ? Every time I make a release for my project, the generated build files are wrong, and it definitively very annoying ! Please, please, made the required corrections and ship them !!! Thanks, Frédéric Pascal, since PDE/UI knows what the user preferences are, couldn't we just pass you a map for the desired values of the following properties and you could set them correctly in the generated build.xml: basews,baseos, basenl, basearch, javacFailOnError, javacDebugInfo, javacVerbose, javacSource, javacTarget. If a map is not passed in (i.e. as during the RelEng build), then it's business as usual for you. *** Bug 38067 has been marked as a duplicate of this bug. *** I don't understand the point to transfer a custom map with the required properties as you can found
every one of them in the preference store of the PDE Plugin !
e.g.
PDEPlugin.getDefault().getPreferenceStore().getString("javacSource");
PDEPlugin.getDefault().getPreferenceStore().getString("javacTarget");
Regarding comment #7, pde-build (the plugin generating the script) is a non-UI plug-in, has no access to preference pages and is lower than pde-ui in the dependency chain. That is why it has no access to the preferences owned by PDE-UI. So if this bug is to be resolved, the only way I could see it happening is if pde-ui passed in the value preferences to pde-build before the build script gets generated. *** Bug 97512 has been marked as a duplicate of this bug. *** The PDE Build part of the problem has been addressed. Closing as fixed. |