Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 553353

Summary: Project Explorer hides contributed projects (EmptyWorkspaceHelper)
Product: [Eclipse Project] Platform Reporter: Eike Stepper <stepper>
Component: UIAssignee: Eike Stepper <stepper>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: daniel_megert, evil_bandit_betamax, kashihara, Lars.Vogel, ma.becker, mistria
Version: 4.14   
Target Milestone: 4.22 M1   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/153169
https://git.eclipse.org/r/153178
https://bugs.eclipse.org/bugs/show_bug.cgi?id=553598
https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/185718
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f9f01df39afba745eee8d5434c9ad5eb179300dd
Whiteboard:
Bug Depends on: 543746, 553598    
Bug Blocks:    

Description Eike Stepper CLA 2019-11-22 06:13:14 EST 
The EmptyWorkspaceHelper that was introduced in bug 543746 makes the wrong assumption that all possible content comes from the physical workspace. Hence it decides to hide contributed virtual projects when no physical workspace projects exist, but this decision is wrong.

As the Project Explorer is a UI component that is fundamentally based on the principle of pluggable contribution of arbitrary (including virtual) content the emptiness detection must consider all content contributions, not just the ones from a single contributor.

In a minute I'll submit a Gerrit patch to address the issue...
Comment 1 Eike Stepper CLA 2019-11-22 06:38:18 EST 
I can't seem to be able to push my commit to Gerrit from within my IDE ;-(

My correct password is rejected. Why does it ask me for a password at all? Normally my ssh keys are automatically picked up. Di I use a wrong clone URI?
Comment 2 Mickael Istria CLA 2019-11-22 06:40:20 EST 
I also have a patch here. I'll submit it too and we'll compare out proposals to assemble the best pieces of both.
Comment 3 Eclipse Genie CLA 2019-11-22 07:02:10 EST 
New Gerrit change created: https://git.eclipse.org/r/153178
Comment 4 Eike Stepper CLA 2019-11-22 07:02:53 EST 
(In reply to Eike Stepper from comment #1)
> I can't seem to be able to push my commit to Gerrit from within my IDE ;-(
> 
> My correct password is rejected. Why does it ask me for a password at all?
> Normally my ssh keys are automatically picked up. Di I use a wrong clone URI?

Never mind, now I used an Oomph task to clone the repo and all is good!
Comment 5 Eike Stepper CLA 2019-11-22 07:03:48 EST 
(In reply to Mickael Istria from comment #2)
> I also have a patch here. I'll submit it too and we'll compare out proposals
> to assemble the best pieces of both.

Why not. Mine is here: https://git.eclipse.org/r/#/c/153178/
Comment 6 Lars Vogel CLA 2019-11-22 07:26:45 EST 
(In reply to Eike Stepper from comment #4) 
> Never mind, now I used an Oomph task to clone the repo and all is good!

:-)
Comment 7 Matthias Becker CLA 2019-11-22 08:38:30 EST 
(In reply to Eike Stepper from comment #5)
> (In reply to Mickael Istria from comment #2)
> > I also have a patch here. I'll submit it too and we'll compare out proposals
> > to assemble the best pieces of both.
> 
> Why not. Mine is here: https://git.eclipse.org/r/#/c/153178/

and the other one is https://git.eclipse.org/r/#/c/153169/ ?
Comment 8 Matthias Becker CLA 2020-01-16 02:57:59 EST 
How get we get progress on this bug? Any news?
Comment 9 John Moule CLA 2020-09-24 06:30:00 EDT 
Hi,
I was just about to file the following bug [1] and came across this ticket. Do you think this emptyness checker would fix my issue too?

==
[1]
Project Explorer EmptyWorkspaceHelper does not consider filtered content

The EmptyWorkspaceHelper does not display it's useful help ("There are no projects in your workspace.") when there are hidden projects in the workspace, for example Remote Systems Explorer (RSE) projects (RemoteSystemsTempFiles).
Instead of the EmptyWorkspaceHelper checking to see if there are 0 projects in the workspace, instead it should check whether any projects are in the filtered list and therefore should not be considered.
==
Comment 10 Mickael Istria CLA 2020-09-24 06:48:14 EDT 
(In reply to John Moule from comment #9)
> Do you think this emptyness checker would fix my issue too?

Probably.
Comment 11 Eike Stepper CLA 2021-09-23 01:25:44 EDT 
Now that the fix for bug 553598 is available I'm going to push a fix for this bug via Gerrit...
Comment 12 Eclipse Genie CLA 2021-09-23 01:26:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/185718