Bugzilla – Full Text Bug Listing
| Summary: | Find Actions toolbar item is almost invisible and looks disabled | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Ed Merks <Ed.Merks> | ||||||||||||
| Component: | UI | Assignee: | Matthias Becker <ma.becker> | ||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | P3 | CC: | daniel_megert, Lars.Vogel, loskutov, ma.becker | ||||||||||||
| Version: | 4.14 | ||||||||||||||
| Target Milestone: | 4.14 RC1 | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=500618 https://git.eclipse.org/r/153044 https://git.eclipse.org/r/153045 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=efc432d9aed90ced7e7194e80e88995f51a44597 https://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=24814c9af3a59d89d2f1d72c59b442cd038a7e52 |
||||||||||||||
| Whiteboard: | |||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 550932 | ||||||||||||||
| Attachments: |
|
||||||||||||||
See bug 550932 for the icon change and original main bug 500618. I personally like that the button is "almost invisible" (because I usually hide that button anyway) but I agree that it doesn't help the original intent to make it more "more attractive and accessible for end-users" as stated in bug 550932. So from the end-user point of view we are going in the wrong direction here. In this particular case, we could use different icons for dark and light theme, as we are creating the toolitem via code in SearchField, line 141. Or we could use SWT API to change the color of the icon based on the theme (assuming that SWT has such API, I never tried that). (In reply to Lars Vogel from comment #2) > In this particular case, we could use different icons for dark and light > theme, as we are creating the toolitem via code in SearchField, line 141. Or > we could use SWT API to change the color of the icon based on the theme > (assuming that SWT has such API, I never tried that). should I provide a light and dark version of the PNGs? I suspect that a wider stroke would help; the firefox icon that looks the same has a wider stroke. It's it's possible to have some lighter gray alpha at the edges it might look good in both themes (are there only ever two, or is a theme always characterized as light or dark?), but I'm not a graphical designer. I suggest to try first wider stroke as Ed suggested. wider stroke with an outline or some gradient to the outside of the stroke? (In reply to Matthias Becker from comment #6) > wider stroke with an outline or some gradient to the outside of the stroke? Don't know. Please make a suggestion. :-) Created attachment 280725 [details]
current dark
Created attachment 280726 [details]
current light
Created attachment 280727 [details]
proposal dark
Created attachment 280728 [details]
proposal light
I made the stroke thicker (2px instead of 1px) and the color is darker what do you think? (In reply to Matthias Becker from comment #12) > I made the stroke thicker (2px instead of 1px) and the color is darker > > what do you think? I like it I like it better too. :-) New Gerrit change created: https://git.eclipse.org/r/153044 New Gerrit change created: https://git.eclipse.org/r/153045 merge the changes if you like the new icons (In reply to Matthias Becker from comment #17) > merge the changes if you like the new icons +1 from project lead to merge for RC1. It looks IMHO a tiny bit worse in the dark theme but less disabled in the light theme, so it is a good compromise. If no one disagrees, I suggest to merge this. Gerrit change https://git.eclipse.org/r/153044 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=efc432d9aed90ced7e7194e80e88995f51a44597 Gerrit change https://git.eclipse.org/r/153045 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=24814c9af3a59d89d2f1d72c59b442cd038a7e52 |
Created attachment 280695 [details] Compare find icon with disabled navigation icons One of the stated goals of changing Quick Access was to make it more compelling to use. But in the current state it's almost invisible and worse still it simply looks disabled. Perhaps it's been optimized or compromised for dark them. In the attached screen capture, you can see how much it's styled in a way exactly analogous to the disabled navigation arrows from the Help view. The current icon design seems to me to be completely counter productive in terms of achieving the goal of making it more compelling. It's in fact far less noticeable than the previous design. I'm not suggesting we go back to the previous design. I like very much that the overall toolbar is now a noticeably less tall! Perhaps something as simple as making the stokes of the icon wider will quickly and easily provide some much needed improvement. Alternatively, white alpha bending around the stokes to make it stand out rather the blend in both in light theme and dark theme...