Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 552993

Summary: DOT Editor - Add strike through highlighting for the deprecated attribute values
Product: [Tools] GEF Reporter: Tamas Miklossy <miklossy>
Component: GEF DOTAssignee: Zoey Gerrit Prigge <eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 5.3.0 (2019-12)   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
screenshot about the current highlighting none

Description Tamas Miklossy CLA 2019-11-13 07:49:00 EST 
Created attachment 280621 [details]
screenshot about the current highlighting

Currently, the deprecated attribute values are marked with the warning. To be consistent with the other Eclipse Tools (like JDT, MWE2, ...) such elements should be highlighted with the strike through style.

Hint: you can find such an implementation under https://github.com/eclipse/mwe/blob/master/plugins/org.eclipse.emf.mwe2.language.ui/src/org/eclipse/emf/mwe2/language/ui/highlighting/MweHighlightingConfiguration.java#L53
Comment 1 Zoey Gerrit Prigge CLA 2020-01-09 03:39:13 EST 
I pushed the following changes to the master branch:

[552993] Strikethrough highlighting of deprecated ArrowTypes

- implement new DotArrowTypeHSemanticighlightingCalculator based on
DotHtmlLabelSemanticHighlightingCalculator
- add binding to DotArrowTypeUiModule
- add styles (quoted/unquoted) in DotHighlightingConfiguration
- adapt DotSubgrammarHighlighter to allow for style suffix (for
difference in quoted style)
- implement delegation of ArrowType to DotSubgrammarHighlighter in
DotSemanticHighlightingCalculator.
- add corresponding DotHighlightingTest and
DotHighlightingCalculatorTest, change test helper methods to allow for
testing against strikethrough and multiple repeated keywords, adapt
other test(s) accordingly

Signed-off-by: zprigge <zprigge@itemis.com>
https://bugs.eclipse.org/bugs/show_bug.cgi?id=552993

This should implement the wished for feature(s). Will close this bug as resolved/fixed once the correct milestone is ready for selection.
Comment 2 Tamas Miklossy CLA 2020-01-15 05:02:22 EST 
Hello Zoey,

we created the Target Milestone 5.4.0 (2020-03). Now you can set this and resolve the ticket as fixed.
Comment 3 Zoey Gerrit Prigge CLA 2020-01-16 04:52:59 EST 
Resolved as fixed in 5.4.0 (2020-03).