Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 552855

Summary: [release] polarsys.kitalpha 1.4.0
Product: Community Reporter: Wayne Beaton <wayne.beaton>
Component: Proposals and ReviewsAssignee: Eclipse Management Organization <emo>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: benoit.langlois, sharon.corbett, thomas.guiu
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
URL: https://projects.eclipse.org/projects/polarsys.polarsys.kitalpha/releases/1.4.0
Whiteboard:

Description Wayne Beaton CLA 2019-11-08 13:36:59 EST
We'll use this bug to track the release

We require IP Team approval of the IP Log.

We require PMC approval of the release and review materials.

There's help regarding releases in the handbook.

https://www.eclipse.org/projects/handbook/#release
Comment 1 Wayne Beaton CLA 2019-11-08 13:41:46 EST
The project website does not conform to branding requirements. Specifically, the first, and all prominent, reference to the project name must be expressed as "Eclipse Kitalpha" (or "PolarSys Kitalpha" while we complete the merge of the PolarSys forge into projects.eclipse.org; see bug 541051).
Comment 2 Wayne Beaton CLA 2019-11-08 14:02:46 EST
I'm getting a compiler error when I try to build off git://git.polarsys.org/gitroot/kitalpha/kitalpha.git master.

> The type MAConnector must implement the inherited abstract method ObservableElementList.Connector<EObject>.setObservableElementList(ObservableElementChangeHandler<? extends EObject>)

I don't see any build instructions. Is there something that I need to do other than "mvn clean install"?
Comment 3 Wayne Beaton CLA 2019-11-08 14:35:51 EST
The IP Log is approved.

Please add some content to the review's description and forward to the PMC for their approval.
Comment 4 Thomas Guiu CLA 2019-11-14 04:53:18 EST
(In reply to Wayne Beaton from comment #2)
> I'm getting a compiler error when I try to build off
> git://git.polarsys.org/gitroot/kitalpha/kitalpha.git master.
> 
> > The type MAConnector must implement the inherited abstract method ObservableElementList.Connector<EObject>.setObservableElementList(ObservableElementChangeHandler<? extends EObject>)
> 
> I don't see any build instructions. Is there something that I need to do
> other than "mvn clean install"?

We usually don't build localy the product and use artefacts from jenkins.

However I cloned the repo to a brand new folder and run mvn clean install  (maven version is 3.6.1)
Everything ran smoothly.

The error you got is related to a subclass from glazedlists. The missing method is available in the lastest version [1]. This is unexpected since we are using an older version 1.9.0 [2] available in Orbit Build: R20180206163158 [3]. 

[1] https://javadoc.io/static/net.java.dev.glazedlists/glazedlists_java16/1.10.0/ca/odell/glazedlists/ObservableElementList.Connector.html

[2] https://javadoc.io/doc/net.java.dev.glazedlists/glazedlists_java15/1.9.0/ca/odell/glazedlists/ObservableElementList.Connector.html

[3] https://download.eclipse.org/tools/orbit/downloads/drops/R20180206163158/
Comment 5 Wayne Beaton CLA 2019-11-14 13:16:56 EST
> We usually don't build localy the product and use artefacts from jenkins.

Being able to build your code locally is an important part of building community. It's hard to contribute meaningfully to a project that you can't build.

> However I cloned the repo to a brand new folder and run mvn clean install 
> (maven version is 3.6.1)
> Everything ran smoothly.

I did exactly the same thing, but with different results.

> The error you got is related to a subclass from glazedlists. The missing
> method is available in the lastest version [1]. This is unexpected since we
> are using an older version 1.9.0 [2] available in Orbit Build:
> R20180206163158 [3]. 

It looks like I had the newer version cached locally. I turned off the local cache, and it seems to have worked.

$ mvn clean install -DskipTests -Dtycho.localArtifacts=ignore
Comment 6 Wayne Beaton CLA 2019-11-14 23:16:24 EST
The PMC approved the review materials.

I've scheduled the review to conclude on December 4/2019.
Comment 7 Wayne Beaton CLA 2019-12-04 10:42:09 EST
I declare this review successful. Please continue with your release.