Bugzilla – Full Text Bug Listing
Created attachment 280557 [details]
Screencast without active part styling
See still style the CTabFolder and item based on the selection so the user should still be able to see which part is selected but the widget specific styling has been removed.
Removing that should make the CSS engine faster (less work) and reduce inconsistencies.
New Gerrit change created: https://git.eclipse.org/r/152290 Created attachment 280558 [details]
Screenshot
The nice side-effect is that the ugly back column vanishes for free. See screenshot, looks way nice IMHO.
Created attachment 280559 [details]
Vscode
Looking at VScode, it also does not change colors based on the active selection
Benedikt, Matthias, WDYT? Created attachment 280561 [details]
Screencast with another example of active part specific styling
Another screenshot with the current behavior, which IMHO looks bad.
Of course its a matter of taste, but IMHO it looks better without the focus-dependent coloring. Also light theme does not use different background colors. But in light theme, you can better distinguish between active and not-active parts as the tab folder uses different colors. In the screencast in comment 2, I guess there is not enough feedback to the user about which part is actually selected (which is quite an important thing in Eclipse as all the toolbar actions or editor contents rely on that...). Maybe it would be an idea to take the light theme way and make the part backgrounds focus-independent but to use a clearer part tab styling? Created attachment 280563 [details]
Screencast
Benedikt, the tab color is already (and still) different, it uses a strong dark. See attached animated gif. Is that what you had in mind?
Created attachment 280565 [details] Light theme styling (In reply to Lars Vogel from comment #8) > Created attachment 280563 [details] > Screencast > > Benedikt, the tab color is already (and still) different, it uses a strong > dark. See attached animated gif. Is that what you had in mind? The tab font color is a little bit lighter in current dark mode when another tab folder has the focus, the tab folder color does not change. Compared to light theme (see screenshot), you can see a stronger difference there although the part background is not changed. Created attachment 280566 [details]
Tab selection color
I think the color contrast of the selected tab in the dark theme is good, it is similar to what VsCode uses. The light theme under Linux has way less contrast, than the "blue theme" of Windows.
Benedikt, if you want to improve the color contrast for the toolbar for the selected tab, I think we should discuss that in a separate bug.
(In reply to Lars Vogel from comment #5) > Benedikt, Matthias, WDYT? Okay for me. But one thing I still see in the GIFs after you change: The toolbars of the views still change background. Shouldn't we then also change that? (In reply to Matthias Becker from comment #11) > (In reply to Lars Vogel from comment #5) > > Benedikt, Matthias, WDYT? > > Okay for me. > But one thing I still see in the GIFs after you change: The toolbars of the > views still change background. Shouldn't we then also change that? I think they get the color from the tab folder. We can investigate via another bug report, if that can be changed. (In reply to Lars Vogel from comment #12) > (In reply to Matthias Becker from comment #11) > > (In reply to Lars Vogel from comment #5) > > > Benedikt, Matthias, WDYT? > > > > Okay for me. > > But one thing I still see in the GIFs after you change: The toolbars of the > > views still change background. Shouldn't we then also change that? > > I think they get the color from the tab folder. We can investigate via > another bug report, if that can be changed. okay Gerrit change https://git.eclipse.org/r/152290 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5982a6b88d09b78df978a170fcbab50e53e57317 Thanks Benedikt and Matthias for the feedback. New Gerrit change created: https://git.eclipse.org/r/152578 Gerrit change https://git.eclipse.org/r/151506 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=5108b12bf8c2192f6a3aed0f049fb9b62e283317 Gerrit change https://git.eclipse.org/r/152578 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=49a1a5cc8ec3f6320c8e32515c99c03dfd1e6157 |
Created attachment 280556 [details] Screencast Currently our styling for certain widgets depends on the fact if a part is selected or not. I find that distracting, see attached Gif. I suggest we style the widgets the same, no matter if the part is selected or not.