Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 552433

Summary: [Dark theme] Move workaround for LogView Text search to a general setting
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Lars Vogel <Lars.Vogel>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: benedikt.kuntz, Lars.Vogel, ma.becker
Version: 4.14   
Target Milestone: 4.14 M3   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/151647
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4768916e825ad6946898682b8490cadf1d193bf2
Whiteboard:
Bug Depends on:    
Bug Blocks: 551494    
Attachments:
Description Flags
Screenshot before and after
none
Search Boxes on windows none

Description Lars Vogel CLA 2019-10-25 13:06:09 EDT 
I noticed that the Search box in the LogView looks good, but it does not look good in the preference page.

I suggest to remove this local fix and use its styling for all text fields with the search flag.
Comment 1 Lars Vogel CLA 2019-10-25 13:12:10 EDT 
Created attachment 280431 [details]
Screenshot before and after

Before and after on Linux. New styling looks IMHO really, really good.
Comment 2 Eclipse Genie CLA 2019-10-25 13:15:58 EDT 
New Gerrit change created: https://git.eclipse.org/r/151647
Comment 3 Benedikt Kuntz CLA 2019-10-26 06:43:41 EDT 
Created attachment 280433 [details]
Search Boxes on windows

Left: before, right: after.
IMHO: Good to have them in the same style, but definitely looks better on linux. Especially this white border around the box looks nasty in my eyes...
Comment 4 Lars Vogel CLA 2019-10-28 04:34:02 EDT 
(In reply to Benedikt Kuntz from comment #3)
> Created attachment 280433 [details]
> Search Boxes on windows
> 
> Left: before, right: after.
> IMHO: Good to have them in the same style, but definitely looks better on
> linux. 

Thanks for testing.

> Especially this white border around the box looks nasty in my eyes...

I don't think we have control over the white border via CSS.
Comment 5 Lars Vogel CLA 2019-10-28 06:44:31 EDT 
Thanks Benedikt and Matthias for testing.