Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 552069

Summary: Clarify "File Changed" dialog
Product: [Eclipse Project] Platform Reporter: Pierre-Yves Bigourdan <pyvesdev>
Component: TextAssignee: Pierre-Yves Bigourdan <pyvesdev>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: karsten.thoms, Lars.Vogel
Version: 4.13   
Target Milestone: 4.14 M3   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/151347
https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=1d9ab0be7397cec90b590edd547136753efa513f
Whiteboard:
Bug Depends on:    
Bug Blocks: 551494    
Attachments:
Description Flags
Replace/do not replace current dialog none

Description Pierre-Yves Bigourdan CLA 2019-10-13 16:09:43 EDT 
The File Changed dialog indicates that something on the file system has changed externally. However, the two action buttons, "Replace" and "Do not replace" refer to something else, namely the editor's contents. Even though I've been using Eclipse for quite a few years now, I always find myself reading the dialog's text in full to make sure I'm not about to action things the wrong way around.

I suggest we try to clarify the button labels. One idea to make things very explicit: "Replace"/"Do not replace" -> "Replace editor"/"Ignore file system"

I'm happy to contribute a patch once we've agreed on a wording!
Comment 1 Lars Vogel CLA 2019-10-18 02:49:03 EDT 
+1 please provide Gerrit so that we can discuss the wording. I like your first proposal (Replace / Do not replace).
Comment 2 Eclipse Genie CLA 2019-10-20 07:28:25 EDT 
New Gerrit change created: https://git.eclipse.org/r/151347
Comment 3 Karsten Thoms CLA 2019-10-21 06:13:18 EDT 
Could you attach a screenshot of the dialog? Makes it easier to think about a better wording.
Comment 4 Pierre-Yves Bigourdan CLA 2019-10-21 06:16:27 EDT 
Created attachment 280359 [details]
Replace/do not replace current dialog

Here is the current dialog.
Comment 5 Karsten Thoms CLA 2019-10-21 06:36:24 EDT 
Thank you, Pierre-Yves! In general it is cool that you rethink about the messages you see. It is important that messages are clear.
Comment 7 Lars Vogel CLA 2019-10-22 03:28:20 EDT 
Thanks, Pierre-Yves.