Bugzilla – Full Text Bug Listing
|
Description
Sarika Sinha
This needs to be completed before we can update the marketplace entry (bug 558509) Please refer to bug 547710 for changes made during last iteration. I will take a look post M1 releng work. @All, let me know if any of the following bundles are not required to be included in P-build for Java 14, or if there are additional bundles that need to be included:
<module>../../eclipse.jdt.core/org.eclipse.jdt.compiler.tool</module>
<module>../../eclipse.jdt.core/org.eclipse.jdt.core</module>
<module>../../eclipse.jdt.debug/org.eclipse.jdt.launching</module>
<module>../../eclipse.jdt.ui/org.eclipse.jdt.core.manipulation</module>
<module>../../eclipse.jdt.ui/org.eclipse.jdt.junit.core</module>
<module>../../eclipse.jdt.ui/org.eclipse.jdt.ui</module>
<module>../../eclipse.pde.ui/apitools/org.eclipse.pde.api.tools</module>
<module>../../eclipse.pde.build/org.eclipse.pde.build</module>
@Vikas, is <module>../../eclipse.pde.ui/ui/org.eclipse.pde.ui</module> also required?
>>is <module>../../eclipse.pde.ui/ui/org.eclipse.pde.ui</module> also required
org.eclipse.pde.ui is not required for Java 14.
(In reply to Noopur Gupta from comment #3) > @All, let me know if any of the following bundles are not required to be > included in P-build for Java 14, or if there are additional bundles that > need to be included: > > <module>../../eclipse.jdt.core/org.eclipse.jdt.compiler.tool</module> > <module>../../eclipse.jdt.core/org.eclipse.jdt.core</module> > > <module>../../eclipse.jdt.debug/org.eclipse.jdt.launching</module> > > <module>../../eclipse.jdt.ui/org.eclipse.jdt.core.manipulation</module> > <module>../../eclipse.jdt.ui/org.eclipse.jdt.junit.core</module> > <module>../../eclipse.jdt.ui/org.eclipse.jdt.ui</module> > > <module>../../eclipse.pde.ui/apitools/org.eclipse.pde.api.tools</module> > <module>../../eclipse.pde.build/org.eclipse.pde.build</module> > > > @Vikas, is <module>../../eclipse.pde.ui/ui/org.eclipse.pde.ui</module> also > required? <module>../../eclipse.jdt.debug/org.eclipse.jdt.launching</module> This is fine! New Gerrit change created: https://git.eclipse.org/r/156304 Gerrit change https://git.eclipse.org/r/156304 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=95f2ad94b69a15dc6700d9cb21b80e36177c1f4c New Gerrit change created: https://git.eclipse.org/r/156308 Gerrit change https://git.eclipse.org/r/156308 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=4eeb934bd825e52f0f5679265f9bc6647bf6e77e New Gerrit change created: https://git.eclipse.org/r/156317 Gerrit change https://git.eclipse.org/r/156317 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=f07fd69511708aeee3422781b7eea7e4cefabe66 Currently, the P-build is building extra features and plugins from 4.15 M1 along with BETA_JAVA14: https://download.eclipse.org/eclipse/updates/4.15-P-builds/P20200122-0550/features/ As can be seen in the above link, org.eclipse.jdt_3.18.300.v20200110-0905.jar and org.eclipse.pde_3.14.300.v20200110-0905.jar are additional which were not present in 4.13 P-builds: https://download.eclipse.org/eclipse/updates/4.13-P-builds/P20190918-0530/features/ I will check if the P-build gets installed on top of 4.15 M1 build in the current state. Sarika and I tried investigating but haven't been able to find the cause yet. If anyone has any pointers, please suggest. (In reply to Noopur Gupta from comment #12) > I will check if the P-build gets installed on top of 4.15 M1 build in the > current state. https://download.eclipse.org/eclipse/updates/4.15-P-builds/P20200122-0550 is getting installed properly on M1 build and working fine. Marketplace entry can now be created. > Currently, the P-build is building extra features and plugins from 4.15 M1 > along with BETA_JAVA14 > If anyone has any pointers, please suggest. This needs more investigation. I tried installing the latest P build on the latest I build I20200126-1800 but it doesn't seem to work. I am told the solution is already existing. Wonder if this is some version issue. Meanwhile, I added this P build to the composite repo so that we don't have to use the individual P build update site. (In reply to Noopur Gupta from comment #13) > (In reply to Noopur Gupta from comment #12) > > I will check if the P-build gets installed on top of 4.15 M1 build in the > > current state. > https://download.eclipse.org/eclipse/updates/4.15-P-builds/P20200122-0550 > > is getting installed properly on M1 build and working fine. > > Marketplace entry can now be created. (In reply to Jay Arthanareeswaran from comment #14) > I tried installing the latest P build on the latest I build I20200126-1800 > but it doesn't seem to work. I am told the solution is already existing. > Wonder if this is some version issue. It worked on M1 build. The I-build problem could be due to the additional JARs issue which is being investigated. > > Currently, the P-build is building extra features and plugins from 4.15 M1 > > along with BETA_JAVA14 > > If anyone has any pointers, please suggest. > This needs more investigation. Current status: Sravan, Sarika and I spent more time trying to investigate this but couldn't find the cause with the logs. Sravan suggested doing local maven build setup to build the patch locally. I tried the setup twice on my Windows machine but it failed with issues related to long path names on Windows. Looks like it can't be set up on Windows and will need a Linux VM/Fyre setup. Marketplace entry: https://marketplace.eclipse.org/content/java-14-support-eclipse-2020-03-415 New Gerrit change created: https://git.eclipse.org/r/156702 Gerrit change https://git.eclipse.org/r/156702 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=ace9707b65b7db24382c1a3f68d0e9d4e2ccb6bd New Gerrit change created: https://git.eclipse.org/r/156704 Gerrit change https://git.eclipse.org/r/156704 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=d4b5ae01c822950712ca4eda4275026cdc015245 We tried using tycho 1.4 and this gave a correct P Build: https://download.eclipse.org/eclipse/downloads/drops4/P20200128-0510/ Will create a bug in tycho. New Gerrit change created: https://git.eclipse.org/r/156705 Job to be run to add P build to the composite: https://ci.eclipse.org/releng/job/eclipse.releng.addToCompositePbuilds/ (In reply to Sarika Sinha from comment #21) > We tried using tycho 1.4 and this gave a correct P Build: > https://download.eclipse.org/eclipse/downloads/drops4/P20200128-0510/ Installing https://download.eclipse.org/eclipse/updates/4.15-P-builds/P20200128-0510/ on I20200217-1800 works successfully. Please create a new P-build on the latest codebase since the MPE was updated on last Friday - looks like there is an inconsistency with Y build behavior. New Gerrit change created: https://git.eclipse.org/r/158644 Gerrit change https://git.eclipse.org/r/158644 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=67f87185d64a87819835cac13a599c8a1d9e9a52 (In reply to Eclipse Genie from comment #27) > Gerrit change https://git.eclipse.org/r/158644 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=67f87185d64a87819835cac13a599c8a1d9e9a52 > It is not sufficient to just change the update URL to a milestone build for which we want to create a P-build as the created build still adds the extra JARs coming from M1. Needs more work/investigation. (In reply to Noopur Gupta from comment #28) > It is not sufficient to just change the update URL to a milestone build for > which we want to create a P-build as the created build still adds the extra > JARs coming from M1. > > Needs more work/investigation. I will try by updating the feature versions to RC1 everywhere. Before the next P-build, all the components should merge their master to BETA branches so that we don't get any additional issues with the P-build while applying it on the RC1 build. Kalyan, please do the merge for JDT UI. @All, please comment here when the merge is done. (In reply to Noopur Gupta from comment #29) > (In reply to Noopur Gupta from comment #28) > > It is not sufficient to just change the update URL to a milestone build for > > which we want to create a P-build as the created build still adds the extra > > JARs coming from M1. > > > > Needs more work/investigation. > > I will try by updating the feature versions to RC1 everywhere. > > Before the next P-build, all the components should merge their master to > BETA branches so that we don't get any additional issues with the P-build > while applying it on the RC1 build. > > Kalyan, please do the merge for JDT UI. > > @All, please comment here when the merge is done. Done for JDT Debug -> https://git.eclipse.org/r/#/c/158653/ New Gerrit change created: https://git.eclipse.org/r/158659 Done for pde.ui and pde.build repos Gerrit change https://git.eclipse.org/r/158659 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=467a57e5f96011fae0fedbdcfb94c1dda4725e26 (In reply to Eclipse Genie from comment #33) > Gerrit change https://git.eclipse.org/r/158659 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=467a57e5f96011fae0fedbdcfb94c1dda4725e26 Patch build can be started when JDT Core and UI are ready with the merge. (In reply to Noopur Gupta from comment #29) > @All, please comment here when the merge is done. Done for jdt.core (In reply to Jay Arthanareeswaran from comment #35) > (In reply to Noopur Gupta from comment #29) > > @All, please comment here when the merge is done. > > Done for jdt.core Done for jdt.ui https://download.eclipse.org/eclipse/updates/4.15-P-builds/P20200303-0310/ has been created and works well with the RC1 build. (In reply to Noopur Gupta from comment #37) > https://download.eclipse.org/eclipse/updates/4.15-P-builds/P20200303-0310/ > > has been created and works well with the RC1 build. (In reply to Sarika Sinha from comment #23) > Job to be run to add P build to the composite: > https://ci.eclipse.org/releng/job/eclipse.releng.addToCompositePbuilds/ Added to the composite. Gerrit change https://git.eclipse.org/r/158714 was merged to [BETA_JAVA14]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=bfb4b6648b1db97a15a5ca785fa8a74278d9c791 New Gerrit change created: https://git.eclipse.org/r/158714 Steps to move P build to R4_15_maintenance:
1. Checkout releng.aggregator repo from R4_15_maintenance
2. Change the target feature and plugin version corresponding to RC2
3. Change production/sdk/bootstrap/mb4P_hudson.sh ->
export BRANCH=master
export BRANCH=R4_15_maintenance
4. Change P build script on releng.ci -> to use script from R4_15_maintenance branch and not from master
New Gerrit change created: https://git.eclipse.org/r/159151 Gerrit change https://git.eclipse.org/r/159151 was merged to [R4_15_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=a56a1cfad54d28e91e917d0837f671ca456377cf I think we don't have pending work here. |