Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 551418

Summary: [GTK] Remove hack that causes unreadable permission checkboxes
Product: [Eclipse Project] Platform Reporter: Eric Williams <ericwill>
Component: UIAssignee: Eric Williams <ericwill>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel, mistria, paul-eclipse, Vikas.Chandra
Version: 4.14   
Target Milestone: 4.14 M1   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/150063
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3ef00e965323cd7a3ae21ddde3fe480116547651
Whiteboard:
Attachments:
Description Flags
Permissions table on Adwaita with GTK3.24.11
none
Checkbox in control view and theme yaru none

Description Eric Williams CLA 2019-09-24 14:27:08 EDT 
Created attachment 280005 [details]
Permissions table on Adwaita with GTK3.24.11

This is a valuable lesson as to why it's important to fix SWT bugs in SWT.

Bug 312240 was opened to address the fact that (at the time) SWT-GTK check buttons had a grey background area around the button itself. This caused the permissions table to have grey areas all around each check button. Instead of fixing the bug in SWT, a table.setBackgroundMode(SWT.INHERIT_FORCE) line was added to ResourceInfoPage.java.

This is all nice and good, until 9 years later when the permissions table looks like [screenshot attached]. Recent GTK themes (Adwaita, Yaru) like to have check buttons with inverted colors (dark interior background, white check mark).

The color inheritance enforced in ResourceInfoPage.java is now forcing the check buttons to be the same background color as the Table (white), which makes the check buttons quite ugly.

I'll create a Gerrit soon.
Comment 1 Eclipse Genie CLA 2019-09-24 14:30:14 EDT 
New Gerrit change created: https://git.eclipse.org/r/150063
Comment 2 Paul Pazderski CLA 2019-09-24 14:45:02 EDT 
Created attachment 280006 [details]
Checkbox in control view and theme yaru

I recently noticed that checkboxes and radio buttons in SWT Control view and Job Factory view are almost unreadable on Ubuntu.
Is this related or a different problem?

org.eclipse.swt.internal.gtk.theme=Yaru
org.eclipse.swt.internal.gtk.version=3.24.8
Comment 3 Eric Williams CLA 2019-09-24 14:49:53 EDT 
(In reply to Paul Pazderski from comment #2)
> Created attachment 280006 [details]
> Checkbox in control view and theme yaru
> 
> I recently noticed that checkboxes and radio buttons in SWT Control view and
> Job Factory view are almost unreadable on Ubuntu.
> Is this related or a different problem?
> 
> org.eclipse.swt.internal.gtk.theme=Yaru
> org.eclipse.swt.internal.gtk.version=3.24.8

I believe you've run into bug 546552, I was working on that when I discovered this. There is a Gerrit, please let me know if it works for you.
Comment 4 Eric Williams CLA 2019-09-24 14:52:33 EDT 
The attached Gerrit build is failing with some API analysis error, Mickael/Vikas do you have any idea?
Comment 5 Lars Vogel CLA 2019-09-24 18:46:40 EDT 
Thanks, Eric
Comment 7 Eric Williams CLA 2019-10-08 13:26:24 EDT 
Verified in I20191008-0600.