Bugzilla – Full Text Bug Listing
|
Description
Lars Vogel
Created attachment 279962 [details]
Prototype
Prototype screenshot attached, of course the color is not fitting but you should be able to see the intended change.b
New Gerrit change created: https://git.eclipse.org/r/149924 Created attachment 279981 [details] Comparison with the native macOS search field (below) (In reply to Lars Vogel from comment #1) > Created attachment 279962 [details] > Prototype > > Prototype screenshot attached, of course the color is not fitting but you > should be able to see the intended change.b I agree about the color. It's too dark. I suggest do make it similar to the native macOS search field. The "problem" here is that we need an icon that can be visible also in the dark theme. The native search field changes the icon color to some white color when switched to dark mode. Created attachment 279982 [details]
native macOS search field in dark mode
(In reply to Lars Vogel from comment #0) > I suggest to use a find related icon for Find Action instead of a magic wand I also don't like the text "Find Actions" text in the text box. What's wrong with "Quick Access". I have the feeling that "Quick Access" together with the proposed Icon would be a good solution - it would help new users to understand what the field is for and experienced eclipse user still will still recognise it. The new name was discussed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=547755. Please comment here. Matthias, would be great if you could take this one and provide a nicer icon for Quick Access / Find Actions. Once we have this, I suggest to starting using this icon also via Bug 551326 for other search actions. New Gerrit change created: https://git.eclipse.org/r/150233 Created attachment 280059 [details]
icon proposal in light theme
Created attachment 280060 [details]
icon proposal in dark theme
(In reply to Lars Vogel from comment #7) > Matthias, would be great if you could take this one and provide a nicer icon > for Quick Access / Find Actions. > > Once we have this, I suggest to starting using this icon also via Bug 551326 > for other search actions. I just pushed a proposal. See screenshots. You you pls. provide screenshots from windows and linux in light and dark theme? New Gerrit change created: https://git.eclipse.org/r/150235 Created attachment 280075 [details]
Dark Linux
Created attachment 280076 [details]
Light Linux
Looks definitely better, maybe we should have the lines a bit thicker so that is does look less disabled in the light theme?
Removed milestone as no one reacted to https://www.eclipse.org/lists/eclipse-dev/msg11217.html. (In reply to Lars Vogel from comment #7) > Matthias, would be great if you could take this one and provide a nicer icon > for Quick Access / Find Actions. > > Once we have this, I suggest to starting using this icon also via Bug 551326 > for other search actions. I just though again about the icon for the "Quick Access" aka. "Find Actions" toolbar entry. I really like the "magnifier" icon. macOS uses the same in finder. And also the (system wide) "Spotlight Search" uses a simple magnifier icon. See https://support.apple.com/en-us/HT204014#targetText=Search%20with%20Spotlight,%2C%20double%2Dclick%20the%20item. They also have an icon in their toolbar. But if we also want to replace the "flashsight" icon for the "normal" Search we have to be carefully. The "Search" and the "Quick Access" aka. "Find Actions" do different things in both you can find stuff - but different stuff. Maybe we could use my very minimalistic magnifier icon for the "Quick" access and use a more colorful icons for the "Search" (something in the direction of Wim's proposal here: https://bugs.eclipse.org/bugs/attachment.cgi?id=280174 ). So the icons would express that in both you can do similar but different things because the icon is similar but different as well. Created attachment 280236 [details]
light theme
Created attachment 280237 [details]
dark theme
Sure. Here is the icon in the two major themes. If you like this I can submit to Gerrit again.
(In reply to Wim Jongman from comment #18) > Created attachment 280237 [details] > dark theme > > Sure. Here is the icon in the two major themes. If you like this I can > submit to Gerrit again. Sorry. I misread. I like Matthias' minimalistic magnifier for quick search too. I can replace the flashlight for my magnifier but I think that it is a different bug. Is there already a bug for this? I plan to merge this tomorrow if I don't get any vetos til then. (In reply to Matthias Becker from comment #20) > I plan to merge this tomorrow if I don't get any vetos til then. +1 (In reply to Matthias Becker from comment #20) > I plan to merge this tomorrow if I don't get any vetos til then. +1 for merging now so we have it tomorrow. And change the text to "Find..." or "Find" <fistbump> (In reply to Wim Jongman from comment #23) > And change the text to "Find..." or "Find" <fistbump> This bug is about the icon only. (In reply to Matthias Becker from comment #24) > (In reply to Wim Jongman from comment #23) > > And change the text to "Find..." or "Find" <fistbump> > > This bug is about the icon only. Worth to try ;) Gerrit change https://git.eclipse.org/r/150233 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=14f9358ec46a258ec23352a5ea101e60d47c213f Gerrit change https://git.eclipse.org/r/150235 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=21ae795685346499da0e3c2cf7c9b5766ee5387f (In reply to Matthias Becker from comment #20) > I plan to merge this tomorrow if I don't get any vetos til then. Done. Lars, I presume you added 'Security_Advisories' by mistake. I've removed it again. (In reply to Dani Megert from comment #29) > Lars, I presume you added 'Security_Advisories' by mistake. I've removed it > again. +1 New Gerrit change created: https://git.eclipse.org/r/151468 Gerrit change https://git.eclipse.org/r/151468 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.images.git/commit/?id=c3dce24f77f3ca4bd476f6462a209a73e6f97ac0 Thanks Matthias. I think this one is fixed. |