Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 551180

Summary: Debug Shell can't evaluate/inspect anymore
Product: [Eclipse Project] JDT Reporter: Andrey Loskutov <loskutov>
Component: DebugAssignee: Andrey Loskutov <loskutov>
Status: VERIFIED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: mistria, sarika.sinha
Version: 4.14   
Target Milestone: 4.14 M1   
Hardware: PC   
OS: All   
See Also: https://git.eclipse.org/r/149729
https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=0696ed18f699320d694dd8efa2ea68b6c192ae90
Whiteboard:
Bug Depends on:    
Bug Blocks: 547683    

Description Andrey Loskutov CLA 2019-09-18 03:42:31 EDT
Try to debug this code:

public class Test {
	public static void main(String[] args) {
		String string = "hello";
		System.out.println(string); // breakpoint here and evaluate "args" or "string"
	}
}

Put a breakpoint at sys out.
Open Debug Shell.
Enter "args" or "string" and try to evaluate.
You will see (at least on Linux I20190916-1800 build) that all buttons (except "Clear Console") in the Debug Shell view are disabled, so no evaluation/inspection is possible.

Also notice that while selection in the Debug Shell is changed, the buttons "flicker" because it looks like they enablement is quickly evaluated to "enabled" and then immediately to "disabled".

Probably regression coming from platform UI, have not bisected yet.
Also haven't checked if this is Linux only issue is (which would mean we have SWT regression).
Comment 1 Andrey Loskutov CLA 2019-09-18 03:59:36 EDT
Build SDK-I20190915-1800 is OK, build I20190916-1800 is broken.
Comment 2 Andrey Loskutov CLA 2019-09-18 04:08:25 EDT
This is a regression introduced via bug 547683.
Reverting https://git.eclipse.org/r/142866 fixes the problem here.
Comment 3 Eclipse Genie CLA 2019-09-18 04:22:52 EDT
New Gerrit change created: https://git.eclipse.org/r/149729
Comment 4 Sarika Sinha CLA 2019-09-18 04:43:03 EDT
Same on Mac, Hover and Watch works. But Inspect and Execute appears and vanishes most of the time. Rarely it stays and can be seen.
Comment 5 Andrey Loskutov CLA 2019-09-18 05:03:13 EDT
(In reply to Eclipse Genie from comment #3)
> New Gerrit change created: https://git.eclipse.org/r/149729

Sarika, can you please check if this patch works on Mac and Windows?
Comment 6 Sarika Sinha CLA 2019-09-18 05:32:59 EDT
(In reply to Andrey Loskutov from comment #5)
> (In reply to Eclipse Genie from comment #3)
> > New Gerrit change created: https://git.eclipse.org/r/149729
> 
> Sarika, can you please check if this patch works on Mac and Windows?

Does not work on Mac with the patch.
Comment 8 Andrey Loskutov CLA 2019-09-18 11:14:51 EDT
Will resolve after tomorrow's build.
Comment 9 Sarika Sinha CLA 2019-10-09 05:36:57 EDT
Created follow up Bug 551953 for Mac.

Build id: I20191008-1800