Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 551163

Summary:

[Dark Theme] Selectable Form Editor Title should be dark when Eclipse is in dark theme

Product:

[Eclipse Project] Platform

Reporter:

Nobody - feel free to take it <nobody>

Component:

Assignee:

Platform-UI-Inbox <Platform-UI-Inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Lars.Vogel, ma.becker, sebastian.ratz

Version:

4.12

Target Milestone:

---

Hardware:

Macintosh

OS:

Mac OS X

See Also:

https://git.eclipse.org/r/149784
https://bugs.eclipse.org/bugs/show_bug.cgi?id=531532
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4edf8013b69ffb339cf6d9fc7c2096d0da22be52

Whiteboard:

Attachments:

Description	Flags
Label used (not selectable)	none
Text used (selectable)	none
Text / StyledText comparison	none
Background of Message Hyperlink	none

Description Nobody - feel free to take it

2019-09-17 08:25:05 EDT

Created attachment 279906 [details]
Label used (not selectable)

With 2019-06 it is possible to make the Title of a Form selectable.

See https://help.eclipse.org/2019-06/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fui%2Fforms%2Fwidgets%2FForm.html&anchor=setTitleTextSelectable(boolean)

This has been implemented by using a Text control instead of a Label, in case of the title being selectable.
In the Dark Theme this leads to the title being rendered with a different background as the Titlebar of the Form. (See the attachement)

Comment 1 Nobody - feel free to take it

2019-09-17 08:25:39 EDT

Created attachment 279907 [details]
Text used (selectable)

Comment 2 Sebastian Ratz

2019-09-18 11:58:36 EDT

The text color is also different in the Text.

There is too much operating system influence going on here.

I changed the Text to a StyledText and now it looks 100% identical (foreground color, background color, position) to the Label.

I tested it on Windows using Light and Dark themes.

Comment 3 Eclipse Genie

2019-09-18 12:02:07 EDT

New Gerrit change created: https://git.eclipse.org/r/149784

Comment 4 Lars Vogel

2019-09-18 12:06:08 EDT

(In reply to Sebastian Ratz from comment #2)
> The text color is also different in the Text.
> 
> There is too much operating system influence going on here.
> 
> I changed the Text to a StyledText and now it looks 100% identical
> (foreground color, background color, position) to the Label.
> 
> I tested it on Windows using Light and Dark themes.

Can you share some screnshots?

Comment 5 Sebastian Ratz

2019-09-18 12:46:45 EDT

Created attachment 279915 [details]
Text / StyledText comparison

Done

Comment 6 Lars Vogel

2019-09-18 15:00:31 EDT

I hoped that this change would be about fixing the "Expandable headers" as found in the MANIFEST.MF editor Dependencies tab, selection "Automated Management of Dependencies".'in the dark theme.

Unfortunately, not.

This fix looks good to me.

Comment 7 Nobody - feel free to take it

2019-09-19 03:08:37 EDT

Created attachment 279924 [details]
Background of Message Hyperlink

Change looks good.
Any ideas how the background of the hyperlink can be changed?
As far as I can see the background color is determined by CSS similar to the Text control.

Comment 8 Eclipse Genie

2019-09-19 04:01:15 EDT

Gerrit change https://git.eclipse.org/r/149784 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4edf8013b69ffb339cf6d9fc7c2096d0da22be52

Comment 9 Lars Vogel

2020-04-17 10:41:26 EDT

I think this one is fixed, please reopen if I'm wrong