Bugzilla – Full Text Bug Listing
| Summary: | Use ToolItem "Find Actions" quick access similar to the perspective switcher | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||||||||||||
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> | ||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||
| Severity: | normal | ||||||||||||||||
| Priority: | P3 | CC: | daniel_megert, Lars.Vogel, ma.becker, mistria, wim.jongman | ||||||||||||||
| Version: | 4.13 | ||||||||||||||||
| Target Milestone: | 4.14 M1 | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | Linux | ||||||||||||||||
| See Also: |
https://git.eclipse.org/r/149920 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7ad658f38c5a22456ceac3f819dd615dbe3bde62 https://bugs.eclipse.org/bugs/show_bug.cgi?id=551324 |
||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Bug Depends on: | 500618 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
No objection here, I'm just not sure how this can be implemented with current code as we receive a composite as parent (so can't easily create a ToolItem without creating a nested toolbar). Created attachment 279960 [details]
Light theme newbbbbbb
Created attachment 279961 [details]
Dark theme with ToolItem
New Gerrit change created: https://git.eclipse.org/r/149920 Created attachment 279983 [details]
Look when you start eclipse but you have not yet clicked on the "Find Actions"
Created attachment 279984 [details]
Look after you have clicked the "Find Actions" once.
This looks strange. Once I have clicked the "Find Actions" it stays "pressed" even after closing the search popup. This is somehow inconsistent.
Btw: What was wrong with the input field. I liked it very much because you directly could see that you can enter some text in here. I think that was much easier to "discover" that feature. (In reply to Matthias Becker from comment #7) > What was wrong with the input field. It was having major accessibility issues, such as being totally unusable with a screen reader. Also, the technical debt of this widget was really huge. A dialog doesn't have any of such issues. In a former patch, I tried keeping the text field and the dialog together, but feedback was that it was too inconsistent. So we ended up with the natural way things work: buttons and dialogs. This doesn't add any extra required click nor keystroke, make things more factorized in term of workflow (same workflow with or without search field) and code, it fully accessible, make code so much cleaner that we can increase the value of Quick Assist (by making it extensible, non-blocking and so on...). It was often compared to the firefox search field, but the difference is that the Firefox search field saves some clicks and keystrokes, so it makes things easier. It has never been the case for the quick access field. Other "hyper" IDEs don't show such field for their unified search and still people seem to use it more on those IDEs than they seem to use it in the Eclipse IDE. So I'm also skeptical of the discoverability the text field brought compared to the current state with a clearer label and an icon. > I liked it very much I liked it too, until I realized that I don't really care as a user that it got replaced. (In reply to Matthias Becker from comment #6) > Created attachment 279984 [details] > Look after you have clicked the "Find Actions" once. > > This looks strange. Once I have clicked the "Find Actions" it stays > "pressed" even after closing the search popup. This is somehow inconsistent. Fixed in latest patchset. (In reply to Lars Vogel from comment #9) > (In reply to Matthias Becker from comment #6) > > Created attachment 279984 [details] > > Look after you have clicked the "Find Actions" once. > > > > This looks strange. Once I have clicked the "Find Actions" it stays > > "pressed" even after closing the search popup. This is somehow inconsistent. > > Fixed in latest patchset. If I don't hear more concerns I plan to merge tonight, the current button looks IMHO misplaced in the toolbar. (In reply to Lars Vogel from comment #9) > (In reply to Matthias Becker from comment #6) > > Created attachment 279984 [details] > > Look after you have clicked the "Find Actions" once. > > > > This looks strange. Once I have clicked the "Find Actions" it stays > > "pressed" even after closing the search popup. This is somehow inconsistent. > > Fixed in latest patchset. Not it's not. It still looks as in my screenshots. (In reply to Lars Vogel from comment #10) > (In reply to Lars Vogel from comment #9) > > (In reply to Matthias Becker from comment #6) > > > Created attachment 279984 [details] > > > Look after you have clicked the "Find Actions" once. > > > > > > This looks strange. Once I have clicked the "Find Actions" it stays > > > "pressed" even after closing the search popup. This is somehow inconsistent. > > > > Fixed in latest patchset. > > If I don't hear more concerns I plan to merge tonight, the current button > looks IMHO misplaced in the toolbar. I have concerns (see comment above). ;-) (In reply to Matthias Becker from comment #11) > Not it's not. > It still looks as in my screenshots. Looks like I pushed wrong version. New update available. Lets move the discussion to Gerrit. Gerrit change https://git.eclipse.org/r/149920 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7ad658f38c5a22456ceac3f819dd615dbe3bde62 This bug looks very similar to bug 551324. (In reply to Dani Megert from comment #15) > This bug looks very similar to bug 551324. This one is about using the correct widget the other one is about the option to hide the text Created attachment 280171 [details]
Proposal
Sorry for being so late.
I like the replacement of the quick access but not so much the look of the button.
"Find Actions" is confusing. Actions is Eclipse interal lingo. I propose to replace with Find... (you cannot find actions. You can find views, commands, menus, preferences, etc..)
The icon looks like a wizard wand. Should be a looking glass or something simmilar.
Please look at my proposal.
|
Created attachment 279901 [details] Screenshot Instead of using a button for "Quick Access/Find Action", I suggest to use the same widgets as the perspective switcher, e.g., ToolItems and Labels.