Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 551093

Summary:

[Quick Access] Button enlarges toolbar on Windows

Product:

[Eclipse Project] Platform

Reporter:

Paul Pazderski <paul-eclipse>

Component:

Assignee:

Paul Pazderski <paul-eclipse>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, Lars.Vogel

Version:

4.14

Target Milestone:

4.14 M1

Hardware:

OS:

Windows 7

See Also:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=500618
https://bugs.eclipse.org/bugs/show_bug.cgi?id=550894
https://git.eclipse.org/r/149569
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0524132f6171d54a38fde6de5e52276e175339a0

Whiteboard:

Bug Depends on:

Bug Blocks:

551494

Attachments:

Description	Flags
Eclipse toolbar on Windows	none

Description Paul Pazderski

2019-09-16 05:07:43 EDT

Created attachment 279872 [details]
Eclipse toolbar on Windows

The new quick access button increase the toolbar height on Windows. See attached screenshot.

At the same time the removed margin from perspective switcher in https://git.eclipse.org/r/#/c/149187/ make the toolbar very small when quick access button is hidden.

Comment 1 Eclipse Genie

2019-09-16 05:09:11 EDT

New Gerrit change created: https://git.eclipse.org/r/149569

Comment 2 Lars Vogel

2019-09-16 06:36:18 EDT

My optionion: If possible the toolbar should have the same size with and without Quick Access.

Comment 3 Eclipse Genie

2019-09-16 11:06:20 EDT

Gerrit change https://git.eclipse.org/r/149569 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0524132f6171d54a38fde6de5e52276e175339a0

Comment 4 Mickael Istria

2019-09-26 04:40:42 EDT

I think Paul and Lars already are working on it.

Comment 5 Paul Pazderski

2019-09-26 05:22:40 EDT

Actually I forgot to close it. This particular thing was fixed with my change. I might complain again if all the ongoing quick access and perspective toolbar discussion/changing settles down.

Comment 6 Paul Pazderski

2019-10-09 06:08:17 EDT

Verified in some older integration build but also obsolete due to other changes in meantime.
Toolbar is not to large in I20191009-0300.