Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 551053

Summary:	Catch exceptions on session close with dirty state because a distant resource is not reachable
Product:	[Modeling] Sirius	Reporter:	Steve Monnier <steve.monnier>
Component:	Diagram	Assignee:	Steve Monnier <steve.monnier>
Status:	CLOSED FIXED	QA Contact:	Jerome Pequery <jerome.pequery>
Severity:	normal
Priority:	P3	CC:	laurent.redor
Version:	6.2.2
Target Milestone:	6.3.0
Hardware:	PC
OS:	Windows 10
See Also:	https://git.eclipse.org/r/149480 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a180a55700cbd57922d030f889d2264ed349889a https://git.eclipse.org/r/150586 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6548447cde3fd9ff2ef1f52c0ca58e1343b77461 https://git.eclipse.org/r/152664
Whiteboard:
Bug Depends on:
Bug Blocks:	552679, 553048

Description Steve Monnier

2019-09-13 08:39:04 EDT

When closing a session with a dirty state, a popup is opened to ask the user if he want to save before closing. If the choice is to save, it is saved as expected but some exception are thrown because some refresh are triggered even though the session is already closed. These exception should be silently catched.
I need to find if this can be reproduced without remote resources.

Comment 1 Eclipse Genie

2019-09-13 08:44:54 EDT

New Gerrit change created: https://git.eclipse.org/r/149480

Comment 2 Steve Monnier

2019-09-13 08:46:06 EDT

A different approach could be to prevent some refresh if we can properly detect beforehand that the session is closed or closing. Maybe this could be located in org.eclipse.sirius.diagram.ui.tools.api.permission.EditPartAuthorityListener.doRefreshEditMode(boolean, DDiagramEditor, EObject)

Comment 3 Eclipse Genie

2019-09-18 17:28:05 EDT

Gerrit change https://git.eclipse.org/r/149480 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a180a55700cbd57922d030f889d2264ed349889a

Comment 4 Laurent Redor

2019-10-04 06:09:38 EDT

Validated by Jérôme on a team environment with specific team scenario.

Comment 5 Eclipse Genie

2019-10-04 09:20:31 EDT

New Gerrit change created: https://git.eclipse.org/r/150586

Comment 6 Eclipse Genie

2019-10-04 09:51:03 EDT

Gerrit change https://git.eclipse.org/r/150586 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=6548447cde3fd9ff2ef1f52c0ca58e1343b77461

Comment 7 Eclipse Genie

2019-11-14 07:39:39 EST

New Gerrit change created: https://git.eclipse.org/r/152664

Comment 8 Pierre-Charles David

2019-12-09 02:56:16 EST

Available in Sirius 6.3.0, see https://wiki.eclipse.org/Sirius/6.3.0