Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 550688

Summary: ?d at end of update site causes downloaded artifacts to be broken
Product: Community Reporter: Jonas Hungershausen <jonas.hungershausen>
Component: WebsiteAssignee: phoenix.ui <phoenix.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: chris.guindon, denis.roy, frederic.gurr
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/#/c/149074/
https://git.eclipse.org/c/www.eclipse.org/errors.git/commit/?id=2ee22a20e0b34c061a911e742094f73387ead558
Whiteboard:

Description Jonas Hungershausen CLA 2019-09-03 06:59:14 EDT 
When clicking on the link to an update site on download.eclipse.org (for example https://download.eclipse.org/dartboard/) it appends a ?d parameter at the end.

When copying this URL into eclipse it doesn't strip the parameter but that causes the artifacts from the site to be broken: "Problems downloading artifact Downloaded stream not a valid archive. Check the server." and "MD5 hash is not as expected". 

Would it be possible to remove the ?d or make it respond with the valid update site contents?
Comment 1 Frederic Gurr CLA 2019-09-03 13:11:40 EDT 
AFAICR there was a request to add the "?d" parameter by default, so people can see the contents of the directory in the browser. So "this is a feature, not a bug" ;).
Comment 2 Christopher Guindon CLA 2019-09-03 14:14:26 EDT 
(In reply to Frederic Gurr from comment #1)
> AFAICR there was a request to add the "?d" parameter by default, so people
> can see the contents of the directory in the browser. So "this is a feature,
> not a bug" ;).

I did not know that! 

Closing as won't fix!
Comment 3 Jonas Hungershausen CLA 2019-09-03 14:39:33 EDT 
Just for clarification: What's the difference between https://download.eclipse.org/dartboard/release/ and https://download.eclipse.org/dartboard/release/?d then? Both show the explainer page afaics.
Comment 4 Frederic Gurr CLA 2019-09-04 10:46:11 EDT 
(In reply to Jonas Hungershausen from comment #3)
> Just for clarification: What's the difference between
> https://download.eclipse.org/dartboard/release/ and
> https://download.eclipse.org/dartboard/release/?d then? Both show the
> explainer page afaics.
@Chris: Do you know why the ?d option seems to be redundant here?
Comment 5 Denis Roy CLA 2019-09-04 10:54:42 EDT 
If you have an index.html page in the directory, it will be shown, not ?d. When no suitable index is found, ?d is shown.

https://download.eclipse.org/technology/linuxtools/
Comment 6 Jonas Hungershausen CLA 2019-09-04 14:06:24 EDT 
(In reply to Denis Roy from comment #5)
> If you have an index.html page in the directory, it will be shown, not ?d.
> When no suitable index is found, ?d is shown.
> 
> https://download.eclipse.org/technology/linuxtools/

Interesting, but it seems that it doesn't matter whether or not the parameter is present, as the result seems to be the same on both the cases (present index.html and not). Would it be possible to deprecate this behaviour altogether? 

Otherwise it might be worth looking into stripping the parameter in eclipse, as it literally states on the explainer page "This URL is an Eclipse software repository" which refers to the current URL (in the address bar of the browser). 

There could potentially be a lot of people out there that tried copying the URL into eclipse and then got a very cryptic error.
Comment 7 Denis Roy CLA 2019-09-04 14:08:55 EDT 
Yes, I understand what you mean. Let's remove it altogether.
Comment 8 Denis Roy CLA 2019-09-06 13:14:12 EDT 
Genie is on vacation... https://git.eclipse.org/r/#/c/149074/