Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 550651

Summary: Improve readability of CSS code around ViewCSSImpl#getComputedStyle
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Lars Vogel <Lars.Vogel>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel
Version: 4.13   
Target Milestone: 4.14 M1   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/148711
https://git.eclipse.org/r/148715
https://git.eclipse.org/r/148719
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=296571c9eb10b0ab3cb153bb487f34462cef7cb5
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=501326592cbf446a9a0f48a5a15b9f2e215f54a7
Whiteboard:
Bug Depends on:    
Bug Blocks: 550662    

Description Lars Vogel CLA 2019-09-02 07:51:51 EDT 
I think the CSS code around ViewCSSImpl#getComputedStyle should use some caching. During startup org.eclipse.e4.ui.css.core.impl.dom.ViewCSSImpl.getComputedStyle(List, Element, String) is called 1489 times and takes 887ms according to Yourkit.

As the code is harder to read, this bug is to make it easier to read so that a followup bug might add some kind of caching.
Comment 1 Eclipse Genie CLA 2019-09-02 08:09:34 EDT 
New Gerrit change created: https://git.eclipse.org/r/148711
Comment 2 Eclipse Genie CLA 2019-09-02 08:41:57 EDT 
New Gerrit change created: https://git.eclipse.org/r/148715
Comment 3 Eclipse Genie CLA 2019-09-02 08:58:10 EDT 
New Gerrit change created: https://git.eclipse.org/r/148719