Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 550621

Summary: [console] Improve input handling in IOConsole
Product: [Eclipse Project] Platform Reporter: Paul Pazderski <paul-eclipse>
Component: DebugAssignee: Paul Pazderski <paul-eclipse>
Status: VERIFIED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: akurtakov, sarika.sinha
Version: 4.11   
Target Milestone: 4.14 M1   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/148661
https://git.eclipse.org/r/148662
https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=8ccad171e66800e09d381954ae51d4c05fd07fa3
https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=225e703a20d41def2152be864b22787b36fb9b64
https://git.eclipse.org/r/150411
https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=e29589544fc939b20b3058187c4e9a487b766cea
https://bugs.eclipse.org/bugs/show_bug.cgi?id=551902
Whiteboard:
Bug Depends on:    
Bug Blocks: 552030    
Attachments:
Description Flags
Improvable user input examples
none
User input example after change none

Description Paul Pazderski CLA 2019-08-30 18:36:56 EDT 
Created attachment 279732 [details]
Improvable user input examples

There are some ugly details in the current handling of user input in console. I made a short video to demonstrate them.
Case 1 was also reported in bug 33790.
Case 2 (type in output before existing input) is imo problematic because if I type before existing input it should not be inserted after.
Case 3 (type when input and output is selected) is the most ugly and inconsistent because it react different if selection start in output and end in input.

Most of these problems raise from the fact that the interface IConsoleDocumentPartitioner only offer a method to test read-only state at a single offset. To fix this I want to extend this interface to test read-only state for a range and some related methods.
Comment 1 Eclipse Genie CLA 2019-08-30 18:38:22 EDT 
New Gerrit change created: https://git.eclipse.org/r/148661
Comment 2 Eclipse Genie CLA 2019-08-30 18:39:35 EDT 
New Gerrit change created: https://git.eclipse.org/r/148662
Comment 3 Paul Pazderski CLA 2019-08-30 18:40:39 EDT 
Created attachment 279733 [details]
User input example after change

Here the same simulated user input demonstration after change.
Comment 6 Eclipse Genie CLA 2019-10-01 01:50:05 EDT 
New Gerrit change created: https://git.eclipse.org/r/150411
Comment 7 Alexander Kurtakov CLA 2019-10-01 01:51:04 EDT 
(In reply to Eclipse Genie from comment #6)
> New Gerrit change created: https://git.eclipse.org/r/150411

Paul, would you please keep an eye on the javadoc side :). I know that in this case it was hidden by the error in bug 447191 preventing generation at all but still :).
Comment 8 Alexander Kurtakov CLA 2019-10-01 01:53:52 EDT 
FWIW it has been visible in old build https://download.eclipse.org/eclipse/downloads/drops4/I20190926-0625/compilelogs/platform.doc.isv.javadoc.txt . But not visible in today's https://download.eclipse.org/eclipse/downloads/drops4/I20190930-1800/compilelogs/platform.doc.isv.javadoc.txt. 
Each build publishes at https://download.eclipse.org/eclipse/downloads/drops4/I20190930-1800/logs.php#javadoc just change the I*** to latest and you'll see the results. 
Others helping me with having clean builds would also be highly appreciated :).
Comment 9 Paul Pazderski CLA 2019-10-01 02:59:25 EDT 
(In reply to Alexander Kurtakov from comment #7)
> Paul, would you please keep an eye on the javadoc side :).

Will do.
Comment 11 Sarika Sinha CLA 2019-10-09 05:46:56 EDT 
Build id: I20191008-1800