Bug 550620

Description Paul Pazderski 2019-08-30 17:57:11 EDT

Created attachment 279729 [details]
Test with problematic inputs

The TextConsoleViewer.override method yields wrong results for some inputs. At this point I wanted to write that there is luckily at the moment almost no situation where such a problematic input occur. But Bugzilla's duplicate finder lead me to bug 197958 which is caused by this buggy method.

A sample input which can produce a visible styling error is
    System.err.print("Exception in thread main java.lang.UnsupportedOperationException: ##");
The first '#' is rendered red but the second is black. There must be no error output before or after (and no newline). If there is more than one line of error output this bug is fortuitously circumvented by the wrong style calculation in IOConsolePartitioner (see bug 550618).

Another error is that 'override' does not add the style if it has no overlapping with any existing style. That led to bug 111256 which was fixed by adding an empty dummy style before override.

Also this implementation can add a new style more than once sometimes or in one branch it may delete an element but does not adjust the loop counter therefore skipping the next element and I think the last branch is unreachable (at least I found no combination to reach it).

I attached a small test class with some inputs which are all failing at the moment. (the TextConsoleViewer.override method must be made static)