Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 550261

Summary:	"Searching..." does not stop in Quick Search dialog
Product:	[Eclipse Project] Platform	Reporter:	Sarika Sinha <sarika.sinha>
Component:	Text	Assignee:	Paul Pazderski <paul-eclipse>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	kdevolder, Lars.Vogel, mistria, paul-eclipse
Version:	4.13
Target Milestone:	4.13 RC1
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=549961 https://bugs.eclipse.org/bugs/show_bug.cgi?id=550288 https://git.eclipse.org/r/148027 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=c58c96bcb725d38350343f31c7a8988853f19709
Whiteboard:
Bug Depends on:
Bug Blocks:	548518

Description Sarika Sinha

2019-08-20 05:55:32 EDT

After searching a word in quick search dialog, the result come and I see the list complete but still "Searching..." stays for ever.

I have JDT Core and JDT debug files from the repository. (Medium sized workspace).


With a single file in the workspace, I do not see any "Searching..." as it gets completed very fast.

Comment 1 Paul Pazderski

2019-08-20 06:21:13 EDT

I'm quite sure the error comes from the maxResults. If you search for something which match less than (I think) 200 times the "Searching..." is removed.

Some minor bug with incremental update and ResourceWalkter.suspend()

Comment 2 Sarika Sinha

2019-08-20 07:50:03 EDT

(In reply to Paul Pazderski from comment #1)
> I'm quite sure the error comes from the maxResults. If you search for
> something which match less than (I think) 200 times the "Searching..." is
> removed.
> 
> Some minor bug with incremental update and ResourceWalkter.suspend()

Yes, if result is very less "Searching..." is removed.

Comment 3 Kris De Volder

2019-08-20 11:28:12 EDT

This was by design really. The search is not 'complete' so the 'Searching...' is shown as a indication of that. Initially I also had the intention of having this search automatically resume if user scrolls down in the view to reveal more elements as they reach the end. I couldn't get this to work properly because adding elements would tend to mess up / reset the views scroll position.

Anyhow, we should probably just disable the progress 'Searching...' indicator when a search with many results hits the maximum.

Comment 4 Eclipse Genie

2019-08-21 04:44:05 EDT

New Gerrit change created: https://git.eclipse.org/r/148027

Comment 5 Paul Pazderski

2019-08-21 12:57:01 EDT

I'll merge it for 4.14M1. If someone want it earlier handle the merge yourself.

Comment 6 Lars Vogel

2019-08-21 13:40:58 EDT

+1 from merge for RC1 from project lead, if you want Paul.

Comment 7 Eclipse Genie

2019-08-24 08:56:47 EDT

Gerrit change https://git.eclipse.org/r/148027 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=c58c96bcb725d38350343f31c7a8988853f19709

Comment 8 Sarika Sinha

2019-08-26 23:53:04 EDT

Eclipse SDK

Version: 2019-09 (4.13)
Build id: I20190826-1800