Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 550101

Summary:	[Quicksearch] Strings not externalized
Product:	[Eclipse Project] Platform	Reporter:	Dani Megert <daniel_megert>
Component:	Text	Assignee:	Mickael Istria <mistria>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	kdevolder, michael.keppler, mistria, paul-eclipse
Version:	4.13
Target Milestone:	4.13 M3
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/147884 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=c0daf761389a45a439c0cf3c2af1c68b22894308
Whiteboard:
Bug Depends on:
Bug Blocks:	548518

Description Dani Megert

2019-08-15 08:54:57 EDT

I20190814-1800.

Strings not externalized.

Just two examples:
QuickSearchDialog.java
plugin.xml

Comment 1 Paul Pazderski

2019-08-15 08:58:55 EDT

Also we should enable warning for non externalized strings for the project. (or error but I prefer warning)

Comment 2 Dani Megert

2019-08-15 09:01:39 EDT

(In reply to Paul Pazderski from comment #1)
> Also we should enable warning for non externalized strings for the project.
> (or error but I prefer warning)
+1

Comment 3 Eclipse Genie

2019-08-18 14:58:17 EDT

New Gerrit change created: https://git.eclipse.org/r/147884

Comment 4 Mickael Istria

2019-08-18 16:06:30 EDT

Should be fixed now.

Comment 5 Eclipse Genie

2019-08-18 16:06:33 EDT

Gerrit change https://git.eclipse.org/r/147884 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=c0daf761389a45a439c0cf3c2af1c68b22894308