Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 550058

Summary:	[Quicksearch] Name mismatch in UI and N&N
Product:	[Eclipse Project] Platform	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Michael Keppler <michael.keppler>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	kdevolder, michael.keppler, mistria
Version:	4.13
Target Milestone:	4.13 M3
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/147773 https://git.eclipse.org/r/147776 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=e4cd3301424512368c53114fd477bbb3503adc73 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=aa49020430c24c9e48f30ddc1cdf13f0c5bd88d5
Whiteboard:
Bug Depends on:
Bug Blocks:	548518

Description Dani Megert

2019-08-14 05:44:09 EDT

I20190813-1800.

Currently two different names are used in the UI for the same feature:

Menu item and command: Quick Search
Dialog title and N&N entry: Quick Text Search

==> Only one must be used consistently

Comment 1 Michael Keppler

2019-08-15 08:39:19 EDT

I just checked in the sources, and the dialog seems to be the only place using "Quick Text Search". Everything else uses the label without "Text".

Also the longer label with the very long shortcut (Ctrl-Alt-Shift-L) can make the menu item rather wide.

Therefore I'd prefer changing the title and new and noteworthy page to the shorter "Quick Search". Agreed?

Side note: The command description has wrong capitalization. Will change "...Text..." to "...text...".

Comment 2 Dani Megert

2019-08-15 08:50:35 EDT

(In reply to Michael Keppler from comment #1)
> I just checked in the sources, and the dialog seems to be the only place
> using "Quick Text Search". Everything else uses the label without "Text".
> 
> Also the longer label with the very long shortcut (Ctrl-Alt-Shift-L) can
> make the menu item rather wide.
> 
> Therefore I'd prefer changing the title and new and noteworthy page to the
> shorter "Quick Search". Agreed?
Yes.

 
> Side note: The command description has wrong capitalization. Will change
> "...Text..." to "...text...".
+1.

Comment 3 Eclipse Genie

2019-08-15 08:50:38 EDT

New Gerrit change created: https://git.eclipse.org/r/147773

Comment 4 Eclipse Genie

2019-08-15 09:03:55 EDT

New Gerrit change created: https://git.eclipse.org/r/147776

Comment 5 Eclipse Genie

2019-08-18 14:44:04 EDT

Gerrit change https://git.eclipse.org/r/147773 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=e4cd3301424512368c53114fd477bbb3503adc73

Comment 6 Mickael Istria

2019-08-18 14:55:41 EDT

Thanks!

Comment 7 Eclipse Genie

2019-08-19 14:43:27 EDT

Gerrit change https://git.eclipse.org/r/147776 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=aa49020430c24c9e48f30ddc1cdf13f0c5bd88d5