Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 549661

Summary: [Win32][DND] FileTransfer can not drop on Portable Device
Product: [Eclipse Project] Platform Reporter: Paul Pazderski <paul-eclipse>
Component: SWTAssignee: Paul Pazderski <paul-eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: nikita
Version: 4.13   
Target Milestone: 4.13 M3   
Hardware: PC   
OS: Windows All   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=547634
https://git.eclipse.org/r/147516
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=72476dd4c1385c8df23092b19d585fecc8f575f4
Whiteboard:

Description Paul Pazderski CLA 2019-07-30 10:26:51 EDT
See also bug 549643 comment 5.

A Portable Device is e.g. an Android smartphone attached trough MTP or PTP.

The old FileTransfer before bug 547634 could not drag files to Windows Explorer where a Portable Device is the drop target. After adding CFSTR_SHELLIDLIST support the Explorer signals to accept the drop but the actual transfer fails always.

It seems as if the target does not like the fake PIDLs we create for ShellIDList. (for details see bug 547634 comment 5ff)

A solution might be to extend our native PathToPIDL function to create real PIDLs and only if that fails (usually if the file does not exist) create fake PIDLs.
Comment 1 Eclipse Genie CLA 2019-08-11 17:08:40 EDT
New Gerrit change created: https://git.eclipse.org/r/147516