Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 549410

Summary:

DOT Editor - Implement redundant HTML attribute validation rule

Product:

[Tools] GEF

Reporter:

Tamas Miklossy <miklossy>

Component:

GEF DOT

Assignee:

Zoey Gerrit Prigge <eclipse>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

unspecified

Target Milestone:

5.3.0 (2019-12) RC1

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Screenshot about the Graphviz error message	none

Description Tamas Miklossy

2019-07-19 02:36:08 EDT

Created attachment 279338 [details]
Screenshot about the Graphviz error message

Given is the following DOT graph with redundant html attributes:

graph {
	1 [label=<
		<FONT COLOR="#EFE8FE" COLOR="#DEEED7">text</FONT>
	>]
}

The DOT Editor should recognize if an HTML attribute is defined more than once and issue corresponding errors, since Graphviz cannot render such DOT graph definitions, see the attached screenshot.

Hint: validation rules for redundant DOT attributes (bug 540330) and for redundant style items (bug 540329) has already been implemented.

Comment 1 Zoey Gerrit Prigge

2019-11-28 06:11:39 EST

I pushed a commit with the following changes to the master branch:

[549410] Dot Html-Like label duplicate attribute error

- implemented error for duplicate Html-like label attribute names in
DotHtmlLikeLabelJavaValidator
- implemented corresponding test case in DotHtmlJavaValidatorTest

Marking this bug as resolved/fixed in 5.3.0 2019-12 RC1.