Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 549393

Summary: DOT Editor - Improve Content Assistant of the style attribute values
Product: [Tools] GEF Reporter: Tamas Miklossy <miklossy>
Component: GEF DOTAssignee: Zoey Gerrit Prigge <eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 5.3.0 (2019-12) M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Tamas Miklossy CLA 2019-07-18 10:25:38 EDT
In the dot graph

graph {
	1 [style="bold, "]
}

the content assist invoked after the comma should propose the possible style attribute values.
Comment 1 Zoey Gerrit Prigge CLA 2019-10-17 07:23:23 EDT
I pushed the following changes to the master branch, which should resolve this bug - can be resolved as fixed once the appropriate milestone can be set:

[549393] Listed Style Attribute Support in DotProposalProvider

-refactored custom prefix matcher to inner class AttributeValueMatcher
-moved setting AttributeValueMatcher to completeAttribute_Value to avoid
setting the matcher for other attribute parts
-included listedAttribute attribute in AttributeValueMatcher to allow
listed attributes (for future expansion to e.g. colorList, separator is
freely specifiable)
-changed conditional (if) block to be set conditional on type of
PrefixMatcher instead of currentModel to correctly single out proposals
for attribute value.
-implement corresponding DotContentAssistTest(s)
Comment 2 Zoey Gerrit Prigge CLA 2019-10-24 05:37:11 EDT
Marking as RESOLVED FIXED in 5.3.0 (2019-12) RC2. (Changes applied see comment #1)
Comment 3 Zoey Gerrit Prigge CLA 2019-10-24 05:43:03 EDT
Sorry, it should have been M2.