Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 548277

Summary: [Win32] Remove 32-bit code
Product: [Eclipse Project] Platform Reporter: Nikita Nemkin <nikita>
Component: SWTAssignee: Nikita Nemkin <nikita>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: ericwill, Lars.Vogel, niraj.modi, platform-swt-inbox
Version: 4.13Flags: Lars.Vogel: pmc_approved+
Target Milestone: 4.13 M1   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/144040
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=8ce998bbd9e65934115002ec95404c37f3156411
https://git.eclipse.org/r/144337
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=eebc5e7cbb549ba580cb7b91ce8443dde9c056dc
Whiteboard:
Bug Depends on:    
Bug Blocks: 548363, 549414    
Attachments:
Description Flags
win32_remove_32bit.xml none

Description Nikita Nemkin CLA 2019-06-14 06:23:53 EDT 
JVM, Platform, SWT GTK and Cocoa ports don't support 32-bit anymore. Let's finish this.

Note that 32-bit build is already broken on Windows and there are currently 70+ minor 32/64 bit compat issues in the code.
Comment 1 Nikita Nemkin CLA 2019-06-14 08:11:38 EDT 
Created attachment 278944 [details]
win32_remove_32bit.xml

Ant script that strips 32-bit comments.
Comment 2 Eclipse Genie CLA 2019-06-14 08:25:06 EDT 
New Gerrit change created: https://git.eclipse.org/r/144040
Comment 3 Eric Williams CLA 2019-06-14 11:04:51 EDT 
There's also some 32-bit code in Callback.c, I believe the assembler stuff is 32-bit can be removed. Also anything relating to Windows CE and other such outdated things.
Comment 5 Eclipse Genie CLA 2019-06-18 06:01:05 EDT 
New Gerrit change created: https://git.eclipse.org/r/144337
Comment 7 Lars Vogel CLA 2019-06-18 08:56:18 EDT 
Nikita, please set milestone and bug status (fixed) if you are done.
Comment 8 Nikita Nemkin CLA 2019-06-18 08:59:48 EDT 
(In reply to Lars Vogel from comment #7)
> Nikita, please set milestone and bug status (fixed) if you are done.

I'll close it tomorrow if I don't find any more 32-bit remnants.
Comment 9 Lars Vogel CLA 2019-06-18 09:15:31 EDT 
(In reply to Nikita Nemkin from comment #8)
> (In reply to Lars Vogel from comment #7)
> > Nikita, please set milestone and bug status (fixed) if you are done.
> 
> I'll close it tomorrow if I don't find any more 32-bit remnants.

Thanks. Sorry for the reminder, I wasn't sure if you knew already the rules for bug closing.