Bug 548221

Comment 1 Lars Vogel 2019-06-13 04:44:10 EDT

Alex, WDYT?

Comment 2 Alexander Kurtakov 2019-06-13 05:30:39 EDT

Overall good idea but last successful build of platform.ui gerrit had 358 warnings https://ci.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/18666/warnings39Result/ . If it will help fixing existing warnings I'm all for it, if it will just add more to the pile I don't see much value.

Comment 3 Alexander Fedorov 2019-06-13 05:41:33 EDT

(In reply to Alexander Kurtakov from comment #2)
> Overall good idea but last successful build of platform.ui gerrit had 358
> warnings
> https://ci.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/18666/
> warnings39Result/ . If it will help fixing existing warnings I'm all for it,
> if it will just add more to the pile I don't see much value.

We can create a ticket to fix warnings in eclipse.platform.ui to be a blocker for this one, and the progress on this will help to make a decision

Comment 4 Alexander Kurtakov 2019-06-13 05:46:55 EDT

That woudl be very welcome outcome for me :). Fixing tens of warnings on each opening of workspace it becomes tiring.

Comment 5 Alexander Fedorov 2019-06-13 05:57:38 EDT

(In reply to Alexander Kurtakov from comment #4)
> That woudl be very welcome outcome for me :). Fixing tens of warnings on
> each opening of workspace it becomes tiring.

There was a Bug 521922 already, reusing it here

Comment 6 Lars Vogel 2019-06-13 18:24:47 EDT

(In reply to Alexander Kurtakov from comment #2)
> Overall good idea but last successful build of platform.ui gerrit had 358
> warnings
> https://ci.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/18666/
> warnings39Result/ . If it will help fixing existing warnings I'm all for it,
> if it will just add more to the pile I don't see much value.

I think the plug-in gives a nice visualization of warnings and issues in the code. I don't think it will add more to the pile but due to its nice visualization it may motivate people to work on warnings and other issues.

Fabian uses it in of our Jenkins builds and he told me that is is very helpful to have it.

Comment 7 Alexander Kurtakov 2019-06-14 00:40:07 EDT

(In reply to Lars Vogel from comment #6)
> (In reply to Alexander Kurtakov from comment #2)
> > Overall good idea but last successful build of platform.ui gerrit had 358
> > warnings
> > https://ci.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/18666/
> > warnings39Result/ . If it will help fixing existing warnings I'm all for it,
> > if it will just add more to the pile I don't see much value.
> 
> I think the plug-in gives a nice visualization of warnings and issues in the
> code. I don't think it will add more to the pile but due to its nice
> visualization it may motivate people to work on warnings and other issues.
> 
> Fabian uses it in of our Jenkins builds and he told me that is is very
> helpful to have it.

+1 from me in this case

Comment 8 Fabian Pfaff 2019-06-14 04:07:56 EDT

This plugin doesn't produce any more warnings. You point it to the output files of other tools as a post-build action and it produces a nice visualization. We're using spotbugs, for example.
What I like about this plugin is that it can show you the warnings that got introduced by the current change, so you can at least fix those and stop adding new warnings.

There's also the possibility to add a "Quality Gate", so the build fails, e.g., if there's x amount or higher new warnings of a certain severity.
But I'm not sure how useful that would be for Eclipse, as not every warning of every tool is always actually an issue.

Comment 9 Lars Vogel 2019-06-14 04:19:02 EDT

(In reply to Fabian Pfaff from comment #8)
> There's also the possibility to add a "Quality Gate", so the build fails,
> e.g., if there's x amount or higher new warnings of a certain severity.
> But I'm not sure how useful that would be for Eclipse, as not every warning
> of every tool is always actually an issue.

This will be of great help

Comment 10 Lars Vogel 2021-02-03 11:14:01 EST

Nothing happened for a long time.