Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 547809

Summary: Dot Graph View - Implement Clusterrank support properly
Product: [Tools] GEF Reporter: Zoey Gerrit Prigge <eclipse>
Component: GEF DOTAssignee: Zoey Gerrit Prigge <eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: miklossy
Version: unspecified   
Target Milestone: 5.1.0 (2019-06)   
Hardware: PC   
OS: Windows 10   
Whiteboard:
Attachments:
Description Flags
simplified Screenshot reproducing the issue none

Description Zoey Gerrit Prigge CLA 2019-05-31 07:35:33 EDT 
Created attachment 278790 [details]
simplified Screenshot reproducing the issue

Currently, if clusterrank is set to global or none, style everything as if it were in the cluster.

By the attribute description and graphviz description (https://www.graphviz.org/doc/info/attrs.html#d:clusterrank) both "global" and "none" currently turn off cluster processing altogether.

We should implement this, too.
Comment 1 Zoey Gerrit Prigge CLA 2019-06-07 10:12:49 EDT 
Hello everybody,

There was the option to fix this in Dot2ZestGraphCopier or in DotAttributes::isCluster. 

Me and Támas agreed, as the defining clusterrank attribute is set on the root graph and hence changes the interpretation on that level, we felt, it would be better suited to implement this in Dot Attribute.

Hence, I created a Pull Request with the following changes:

[547809] Clusterrank awareness in DotAttributes::isCluster

-Make isCluster method aware of clusterrank set in root containing graph
-Implement corresponding DotAttributesTest
-adapt Dot2ZestGraphCopierTest(s)

Imo we can close this bug once the PR has been merged.
Comment 2 Tamas Miklossy CLA 2019-06-07 10:33:18 EDT 
Thank you Zoey for your contribution! I merged your PR into the master branch.

Resolving as fixed in 5.1.0 (2019-06).