Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 547793

Summary: [release] tools.titan 6.6.0
Product: Community Reporter: Wayne Beaton <wayne.beaton>
Component: Proposals and ReviewsAssignee: Eclipse Management Organization <emo>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cydnie.smith, elemer.lelik, gyorgy.rethy, lenard.nagy, sharon.corbett
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
URL: https://projects.eclipse.org/projects/tools.titan/releases/6.6.0-0
Whiteboard:

Description Wayne Beaton CLA 2019-05-30 18:54:10 EDT
We'll use this bug to track the release

We require IP Team approval of the IP Log.

We require PMC approval of the release and review materials.
Comment 1 Wayne Beaton CLA 2019-05-30 18:55:06 EDT
The IP Log is approved.

Please provide a description in the release record and request PMC approval.
Comment 2 Wayne Beaton CLA 2019-05-30 19:28:13 EDT
The CONTRIBUTING file [1] references GerritHub. What is this?

[1] https://github.com/eclipse/titan.core/blob/master/CONTRIBUTING.md
Comment 3 Elemer Lelik CLA 2019-05-31 07:38:37 EDT
Hi Wayne,  

the referenced document is a workflow guide to be followed by Titan contributors, and  we are using GerritHub for code review. 

Do you see any problem with that?

Thank you and best regards

Elemer
Comment 4 Wayne Beaton CLA 2019-05-31 08:59:13 EDT
> the referenced document is a workflow guide to be followed by Titan
> contributors, and  we are using GerritHub for code review. 
> 
> Do you see any problem with that?

I'm not sure.

Who owns the review data?

Are contributors required to have an account with GerritHub?

What personal information does GerritHub harvest?

Does GerritHub respect the ECA check hooks that we install on GitHub repositories?

Why not just use the Gerrit instance provided by the Eclipse Foundation?
Comment 5 Lenard Nagy CLA 2019-06-04 04:03:02 EDT
Hi Wayne,

GerritHub uses GitHub account to authenticate the users participating in a code review. It does not require any personal data other than that already trusted to GitHub.

GerritHub uses the same method to check in code to GitHub as if the person having a GitHub account would, so all the hooks and safeguards are respected - the commit will be done having the privileges of the GitHub user, as if she/he would be doing it manually.

We are using the gerrit provided by the Eclipse Foundation for the repos on the Eclipse Foundation git servers. To put it simply I did not find a way to use EF gerrit with github repositories. Is it possible? If so could You please provide a description? 

Regards
Lenard
Comment 6 Wayne Beaton CLA 2019-06-04 14:58:17 EDT
Does using GerritHub require that users provide any additional grants? e.g. is a contributor required to agree to anything beyond the terms of the project license/ECA?

> We are using the gerrit provided by the Eclipse Foundation for the repos on
> the Eclipse Foundation git servers. To put it simply I did not find a way to
> use EF gerrit with github repositories. Is it possible? If so could You
> please provide a description? 

Why do you want repositories on GitHub when you push your developer community to use Gerrit? i.e. why not just fully host all of your repositories on EF Gerrit?

> Who owns the review data?

The review data (e.g. comments made during the review process) contains important historical/tracking information. Who owns this data?

> We require PMC approval of the release and review materials.

We need PMC approval, please.
Comment 7 Elemer Lelik CLA 2019-06-05 02:41:37 EDT
Hi Wayne,

historically, our primary preference was github, but after a while, apparently due to the high number of repos that caused an extra workload, we have been given only EF gerrit repositories, so we ended up with our codebase split over
two systems.

We and our users would still prefer github due to -sorry to say- better public visibility and more flexibility; the current and rather unfortunate situation is a result of a compromise.
 
Best regards  
Elemer
Comment 8 Lenard Nagy CLA 2019-06-05 04:40:28 EDT
Hi Wayne,

The review data is hosted on the servers of GerritForge Ltd. Their privacy policy is available here:
https://www.gerritforge.com/privacy.html

Basically they do not disclose any private information to third parties.

Also, since GDPR is with us we have full control over our account.

Lenard
Comment 9 Cydnie Smith CLA 2019-06-12 09:15:27 EDT
PMC approval:https://www.eclipse.org/lists/tools-pmc/msg04784.html

I have scheduled this review to conclude June 19.
Comment 10 Cydnie Smith CLA 2019-06-19 08:33:04 EDT
I declare this review successful. Please continue with your release.