Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 5476

Summary:

TVT Text extension/truncation problem in jar packager

Product:

[Eclipse Project] JDT

Reporter:

Scott Fairbrother <scottf>

Component:

Assignee:

Dani Megert <daniel_megert>

Status:

VERIFIED FIXED

QA Contact:

Severity:

minor

Priority:

Version:

1.0

Target Milestone:

---

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
Truncation and Button Scrunching on Jar Packager dialog	none
Java Unicode converted properties file from nl fragment.	none
Same truncation in Japanese translation	none

Description Scott Fairbrother

2001-11-02 11:42:35 EST

Messages are truncated on the Jar Packager Dialog. The message format in the US 
english contains trailing spaces after text with a \ presumably marking end of 
message.  One problem we foud was that the tranlation tool mangles the messages 
where multiple messages (6) are moved onto a single line.  The translators did 
find the problem and correcte, putting the (6) messages on seperate lines.  
However, the messages on the dialog were truncated and the buttons were 
scrunched up.  The workaround to this problem is time consumeing and very error 
prone.  Asking the translators to put in the exact number of blanks after there 
NL text as the number of trailing blenks in the US english is not a permenant 
solution.   
 
The corresponding strings are located in file: 
eclipse\plugins\org.eclipse.jdt.ui\jdt_jar\org\eclipse\jdt\internal\ui\jarpackag
er\JarPackagerMessages.properties

Comment 1 Scott Fairbrother

2001-11-02 11:43:34 EST

Created attachment 61 [details]
Truncation and Button Scrunching on Jar Packager dialog

Comment 2 Scott Fairbrother

2001-11-02 12:35:07 EST

Here are the lines in properties file that are causing the problem:

# Trailing spaces are a workaround
JarManifestWizardPage.jarSealed=JAR 
sealed                                            \ 
JarManifestWizardPage.jarSealedExceptOne=JAR sealed, but 1 package 
unsealed                                            \ 
JarManifestWizardPage.jarSealedExceptSome=JAR sealed, but {0} packages 
unsealed                                            \ 
JarManifestWizardPage.nothingSealed=Nothing 
sealed                                            \ 
JarManifestWizardPage.onePackageSealed=1 package 
sealed                                            \ 
JarManifestWizardPage.somePackagesSealed={0} packages 
sealed                                            \ 
JarManifestWizardPage.error.manifestPathMustBeAbsolute=Manifest file path must 
be absolute (start with /)

Comment 3 Erich Gamma

2001-11-05 07:05:46 EST

we are aware of this problem but couldn't fix for 1.0.
Dani is it addressed in the 2.0 stream?

Comment 4 Dani Megert

2001-11-05 08:45:07 EST

The problem is fixed in the current code stream (build 20011101).

Scott, could you please attach the JarPackagerMessages.properties that causes 
the attached dialog in order to verify the fix.

Comment 5 Scott Fairbrother

2001-11-05 09:52:51 EST

Created attachment 68 [details]
Java Unicode converted properties file from nl fragment.

Comment 6 Dani Megert

2001-11-05 10:24:56 EST

Verified (build 20011101) against attached properties file.
Look is OK, spaces are no longer required.

Note: The 1.0 properties file had to be edited first because the spaces are no 
longer required and because there are new resources on that page.
- added JarManifestWizardPage.sealedPackagesDetailsButton.text= D&etails...
- removed the filling spaces described by this PR

Comment 7 Dan Kehn

2001-11-08 11:22:53 EST

Created attachment 92 [details]
Same truncation in Japanese translation