Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 547320

Summary: [GTK 3.22][Tree] Cannot drag and drop multiple selected items
Product: [Eclipse Project] Platform Reporter: Simeon Andreev <simeon.danailov.andreev>
Component: SWTAssignee: Andrey Loskutov <loskutov>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: daniel_megert, ericwill, loskutov
Version: 4.12   
Target Milestone: 4.12 M3   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=546493
https://git.eclipse.org/r/142191
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=688392fa96012ce6d288e39b9d3e1052dc907c9a
Whiteboard:
Attachments:
Description Flags
Video showing the problem in the Git Staging view. none

Description Simeon Andreev CLA 2019-05-15 08:19:46 EDT
Created attachment 278611 [details]
Video showing the problem in the Git Staging view.

To reproduce:

1. Select 2 source files in the Package Explorer.
2. Drag-and-drop them to another package.
3. Observe that only 1 source was drag-and-dropped.
4. Observe that upon dragging start, only 1 item remain selected.

I noticed this while working with the Git Staging view, since there I always select items and drag-and-drop them to the staged area. Something felt off ever since I updated to a newer Eclipse installation, today I noticed what (this ticket).

Its probably an SWT bug but I'm not sure.


I see this with:

Eclipse SDK
Version: 2019-06 (4.12)
Build id: I20190505-1800

RHEL 7.4
GTK 3.22

I did not see this bug with:

Eclipse SDK
Version: 2019-06 (4.12)
Build id: I20190402-1800
Comment 1 Andrey Loskutov CLA 2019-05-15 08:24:30 EDT
4.12 M1 (build 11.04) is OK, I20190429-1800 is broken.
Comment 2 Eric Williams CLA 2019-05-15 08:53:08 EDT
I tried with I20190429-0240 on Fedora 30, GTK3.24 and did not see the bug. Can you try and see if it happens on Wayland?
Comment 3 Andrey Loskutov CLA 2019-05-15 09:04:08 EDT
Works on SDK-I20190415-0300, broken on SDK-I20190422-1800.
Comment 4 Andrey Loskutov CLA 2019-05-15 09:10:41 EDT
It is a regression from bug 546493. If I revert commit 43987e44f8a5a494a8bb49a18d0c9258dcbace1b, everything works again.
Comment 5 Eclipse Genie CLA 2019-05-15 09:18:56 EDT
New Gerrit change created: https://git.eclipse.org/r/142191
Comment 6 Simeon Andreev CLA 2019-05-15 09:20:41 EDT
(In reply to Eric Williams from comment #2)
> I tried with I20190429-0240 on Fedora 30, GTK3.24 and did not see the bug.
> Can you try and see if it happens on Wayland?

Unfortunately no access to Wayland.
Comment 7 Eric Williams CLA 2019-05-15 09:32:49 EDT
(In reply to Simeon Andreev from comment #6)
> (In reply to Eric Williams from comment #2)
> > I tried with I20190429-0240 on Fedora 30, GTK3.24 and did not see the bug.
> > Can you try and see if it happens on Wayland?
> 
> Unfortunately no access to Wayland.

It's okay, Andrey seems to have fixed it (thanks Andrey!)
Comment 9 Andrey Loskutov CLA 2019-05-16 04:34:28 EDT
Verified in I20190515-1800.
Comment 10 Andrey Loskutov CLA 2019-05-16 04:36:11 EDT
@Eric, would be nice if you could verify the change, in context of GTK4 / Wayland / your original patch for bug 546493 (have no GTK4/Wayland).
Comment 11 Eric Williams CLA 2019-05-16 08:53:19 EDT
(In reply to Andrey Loskutov from comment #10)
> @Eric, would be nice if you could verify the change, in context of GTK4 /
> Wayland / your original patch for bug 546493 (have no GTK4/Wayland).

Will do so tomorrow.
Comment 12 Eric Williams CLA 2019-05-17 12:25:37 EDT
Verified.