Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 547222

Summary: [category] Allow to edit feature properties from "Category Definition" page
Product: [Eclipse Project] PDE Reporter: Alexander Fedorov <alexander.fedorov>
Component: UIAssignee: Alexander Fedorov <alexander.fedorov>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: alexander.fedorov, julian.honnen, Vikas.Chandra
Version: 4.11   
Target Milestone: 4.12 M3   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/142086
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=d78de91bf5e6a376f1077823af759faa356161f5
https://git.eclipse.org/r/142197
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=db2e1df66be7124f65f2bd0055f1f857bba2d8e1
Whiteboard:
Bug Depends on:    
Bug Blocks: 287162    
Attachments:
Description Flags
UI preview for https://git.eclipse.org/r/142086
none
UI after review of https://git.eclipse.org/r/142086 none

Description Alexander Fedorov CLA 2019-05-13 09:17:29 EDT 
Extracted from Bug 287162

Show the property pane on the right when a feature is selected (same as for categories).

The properties can include the feature id & version
Comment 1 Eclipse Genie CLA 2019-05-13 11:58:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/142086
Comment 2 Alexander Fedorov CLA 2019-05-13 13:52:30 EDT 
Created attachment 278592 [details]
UI preview for https://git.eclipse.org/r/142086
Comment 3 Julian Honnen CLA 2019-05-15 07:25:29 EDT 
Thanks, Alexander.
Comment 5 Alexander Fedorov CLA 2019-05-15 09:01:19 EDT 
@Julian N&N?
Comment 6 Julian Honnen CLA 2019-05-15 09:03:20 EDT 
(In reply to Alexander Fedorov from comment #5)
> @Julian N&N?

A general entry for the category editor (including bug 287162) would be great.
Comment 7 Eclipse Genie CLA 2019-05-15 10:11:01 EDT 
New Gerrit change created: https://git.eclipse.org/r/142197
Comment 9 Vikas Chandra CLA 2019-05-16 06:54:48 EDT 
How do you get this UI- https://bugs.eclipse.org/bugs/attachment.cgi?id=278592?

I dont seem to get this

Should we populate version by default
1) It will mimic pre-existing behavior
2) It is easier to remove version than to add one
Comment 10 Alexander Fedorov CLA 2019-05-16 07:03:03 EDT 
Created attachment 278626 [details]
UI after review of https://git.eclipse.org/r/142086
Comment 11 Alexander Fedorov CLA 2019-05-16 07:04:30 EDT 
(In reply to Vikas Chandra from comment #9)
> How do you get this UI-
> https://bugs.eclipse.org/bugs/attachment.cgi?id=278592?
> 
> I dont seem to get this
> 
Sorry, I forgot to update the attachment. Now it is the actual one.
Comment 12 Julian Honnen CLA 2019-05-16 07:21:56 EDT 
(In reply to Vikas Chandra from comment #9)
> Should we populate version by default
> 1) It will mimic pre-existing behavior
> 2) It is easier to remove version than to add one

We've omitted the version by default for consistency with the product editor. Also from bug 287162:

> The feature entries also include the actual version. It would be nice if 
> that was optional. After all, the version is only required in the rare case
> when you include more then one version of the same feature on the same site.
Comment 13 Vikas Chandra CLA 2019-05-21 02:55:07 EDT 
Can the bug submitter/bug assignee please verify this defect for 4.12 M3?
Comment 14 Alexander Fedorov CLA 2019-05-21 03:49:15 EDT 
Eclipse SDK
Version: 2019-06 (4.12)
Build id: I20190520-1805
OS: Windows 10, v.10.0, x86_64 / win32
Java version: 1.8.0_211