Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 547064

Summary:	[console] Unnecessarily linear search in IOConsolePartitioner
Product:	[Eclipse Project] Platform	Reporter:	Paul Pazderski <paul-eclipse>
Component:	Debug	Assignee:	Paul Pazderski <paul-eclipse>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	sarika.sinha
Version:	4.12
Target Milestone:	4.13 M1
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/141745 https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=c30c143d1144602652398e3d76a803445f28efa5
Whiteboard:
Bug Depends on:
Bug Blocks:	549366, 552030

Description Paul Pazderski

2019-05-07 18:39:47 EDT

While computePartitioning already uses binary search getPartition does a linear search.

Also the custom binary search of computePartitioning throws an exception if called while there are no partitions and if the requested range is behind the known partitions it returns a wrong partition (the last known partition).

Comment 1 Eclipse Genie

2019-05-07 18:44:02 EDT

New Gerrit change created: https://git.eclipse.org/r/141745

Comment 2 Eclipse Genie

2019-06-17 13:51:47 EDT

Gerrit change https://git.eclipse.org/r/141745 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=c30c143d1144602652398e3d76a803445f28efa5

Comment 3 Sarika Sinha

2019-07-08 23:43:12 EDT

@Paul,
Just verify the affected working use cases that nothing is broken with this change.

Comment 4 Paul Pazderski

2019-07-09 08:13:37 EDT

Verified with I20190708-1800