Bugzilla – Full Text Bug Listing
| Summary: | [macOS] StyledText link color is wrong in dark mojave mode | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Thomas Singer <ts-swt> | ||||||
| Component: | SWT | Assignee: | Lakshmi P Shanmugam <lshanmug> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | lshanmug, niraj.modi, peter, ts-swt | ||||||
| Version: | 4.12 | ||||||||
| Target Milestone: | 4.13 M1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Mac OS X | ||||||||
| See Also: |
https://git.eclipse.org/r/145093 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=39eec9ce0c110e5b7b0560c372ebb0f6bea4e83b https://git.eclipse.org/r/145215 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=92bcb0b8000cd075049006fdb91aada0360630f3 |
||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Thomas Singer
Created attachment 278509 [details]
Snippet
Created attachment 278510 [details]
Screenshot on macOS 10.14
New Gerrit change created: https://git.eclipse.org/r/145093 Windows and GTK already use the same color as SWT.COLOR_LINK_FOREGROUND. The patch fixes this for Mac. Needs to be tested on 10.14 Dark mode. Gerrit change https://git.eclipse.org/r/145093 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=39eec9ce0c110e5b7b0560c372ebb0f6bea4e83b (In reply to Eclipse Genie from comment #5) > Gerrit change https://git.eclipse.org/r/145093 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=39eec9ce0c110e5b7b0560c372ebb0f6bea4e83b Suggest to make field TextLayout#linkForeground static on cocoa: - As value will be same for all TextLayout instances New Gerrit change created: https://git.eclipse.org/r/145215 Gerrit change https://git.eclipse.org/r/145215 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=92bcb0b8000cd075049006fdb91aada0360630f3 (In reply to Niraj Modi from comment #6) > (In reply to Eclipse Genie from comment #5) > > Gerrit change https://git.eclipse.org/r/145093 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > > ?id=39eec9ce0c110e5b7b0560c372ebb0f6bea4e83b > > Suggest to make field TextLayout#linkForeground static on cocoa: > - As value will be same for all TextLayout instances Thanks Niraj, done with the above commit. Verified on I20190708-1800. |