Bugzilla – Full Text Bug Listing
| Summary: | Remove ability to set MRU via CSS | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> |
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, Lars.Vogel, loskutov, mauromol |
| Version: | 4.11 | ||
| Target Milestone: | 4.17 M3 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: |
https://git.eclipse.org/r/140097 https://bugs.eclipse.org/bugs/show_bug.cgi?id=388476 https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166517 https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166522 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0862444e616c785f5cbc5900e2025952cac1df0d https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=60b49762aabb9eee263a4c968b8742c2ddcabd13 |
||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 563540 | ||
|
Description
Lars Vogel
Actuall all themes specifies this. I create a change to remove it and hope that Andrey has time to respond. As I'm ignoring the existing of the MRU setting, I'm a bad judge if this change will affect MRU haters and lovers. New Gerrit change created: https://git.eclipse.org/r/140097 (In reply to Lars Vogel from comment #1) > Actuall all themes specifies this. I create a change to remove it and hope > that Andrey has time to respond. As I'm ignoring the existing of the MRU > setting, I'm a bad judge if this change will affect MRU haters and lovers. How can you provide a change of which you do not know the impact? (In reply to Dani Megert from comment #3) > (In reply to Lars Vogel from comment #1) > > Actuall all themes specifies this. I create a change to remove it and hope > > that Andrey has time to respond. As I'm ignoring the existing of the MRU > > setting, I'm a bad judge if this change will affect MRU haters and lovers. > How can you provide a change of which you do not know the impact? By asking the expert (Andrey) for his opinion. (In reply to Lars Vogel from comment #4) > > By asking the expert (Andrey) for his opinion. I'm not expert in themes, I always have them disabled. (In reply to Andrey Loskutov from comment #5) > (In reply to Lars Vogel from comment #4) > > > > By asking the expert (Andrey) for his opinion. > > I'm not expert in themes, I always have them disabled. Didn't you implement that the preference overrides the CSS setting? (In reply to Andrey Loskutov from comment #5) > (In reply to Lars Vogel from comment #4) > > > > By asking the expert (Andrey) for his opinion. > > I'm not expert in themes, I always have them disabled. Ha! (In reply to Dani Megert from comment #7) > (In reply to Andrey Loskutov from comment #5) > > (In reply to Lars Vogel from comment #4) > > > > > > By asking the expert (Andrey) for his opinion. > > > > I'm not expert in themes, I always have them disabled. > Ha! Ha ha? Let's stay constructive (In reply to Lars Vogel from comment #6) > (In reply to Andrey Loskutov from comment #5) > > (In reply to Lars Vogel from comment #4) > > > > > > By asking the expert (Andrey) for his opinion. > > > > I'm not expert in themes, I always have them disabled. > > Didn't you implement that the preference overrides the CSS setting? Right, I did this long time ago, see commit https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ead0d552a9cadb8b02bab895e18c51a8c78a2235 for bug 388476. So by default those aren't relevant anymore, except user changes the default. (In reply to Andrey Loskutov from comment #9) > (In reply to Lars Vogel from comment #6) > > (In reply to Andrey Loskutov from comment #5) > > > (In reply to Lars Vogel from comment #4) > > > > > > > > By asking the expert (Andrey) for his opinion. > > > > > > I'm not expert in themes, I always have them disabled. > > > > Didn't you implement that the preference overrides the CSS setting? > > Right, I did this long time ago, see commit > https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=ead0d552a9cadb8b02bab895e18c51a8c78a2235 for bug 388476. So by default > those aren't relevant anymore, except user changes the default. Thanks Andrey, surprised that is already that long ago, feels like short term to me. I will have a closer look next week to see if we can safefy remove the CSS for the default. IIRC you argued that CSS is misuse for this case to which I agree. We could actually also style the preference via CSS if required. No time for detailed testing for this trivial change. CSS engine is not API, so we should simplify remove the CSS handler. See CSSPropertyMruVisibleSWTHandler and its usage. CSS engine is not API, so we should simplify remove the CSS handler. See CSSPropertyMruVisibleSWTHandler and its usage. New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166517 New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166522 Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166517 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0862444e616c785f5cbc5900e2025952cac1df0d Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166522 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=60b49762aabb9eee263a4c968b8742c2ddcabd13 |