Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 545776

Summary:

Export all packages quick fix can corrupt MANIFEST.MF

Product:

[Eclipse Project] PDE

Reporter:

Ed Willink <ed>

Component:

Assignee:

Vikas Chandra <Vikas.Chandra>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, julian.honnen, stephan.herrmann, Vikas.Chandra

Version:

4.10

Target Milestone:

4.12 M1

Hardware:

OS:

Windows 10

See Also:

https://git.eclipse.org/r/139552
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=16c2cb9aaa718e0d66aa427ca0908a0d5f895f7e
https://bugs.eclipse.org/bugs/show_bug.cgi?id=544977

Whiteboard:

Attachments:

Description	Flags
plugin to reproduce the issue	none

Description Ed Willink

2019-03-26 04:34:32 EDT

Applying the Export All Packages to the 2019-03 master of org.eclipse.ocl.examples.codegen leads to a missing line break in the MANIFEST.MF at

 org.eclipse.ocl.examples.codegen.library,
 org.eclipse.ocl.examples.codegen.modelorg.eclipse.emf.codegen.ecore.templates.model,
 org.eclipse.ocl.examples.codegen.oclinecore,

where the long line is new and should have been

 org.eclipse.ocl.examples.codegen.library,
 org.eclipse.ocl.examples.codegen.model,
 org.eclipse.emf.codegen.ecore.templates.model,
 org.eclipse.ocl.examples.codegen.oclinecore,

The new packages are distinctive in that while most packages come from src/... the two in question come from 

emf-gen/org.eclipse.ocl.examples.codegen.model
jet-gen/org.eclipse.emf.codegen.ecore.templates.model

making it look as if a change of classpath prefix causes the separator to get lost.

Comment 1 Ed Willink

2019-03-26 05:11:00 EDT

Also, somewhat simpler, the entire new clause:

Export-Package: org.eclipse.m2m.internal.tests.qvt.oml.debugger;x-internal:=true,
 org.eclipse.m2m.internal.tests.qvt.oml.ui;x-internal:=true,
 org.eclipse.m2m.internal.tests.qvt.oml.ui.completion;x-internal:=true,
 org.eclipse.m2m.internal.tests.qvt.oml.ui.editororg.eclipse.m2m.internal.tests.qvt.oml.ui.mypackage;x-internal:=true,
 org.eclipse.m2m.internal.tests.qvt.oml.ui.mypackage.impl;x-internal:=true,
 org.eclipse.m2m.internal.tests.qvt.oml.ui.mypackage.util;x-internal:=true

in the 2019-03 release of org.eclipse.m2m.tests.qvt.oml.ui

Missing separator is where classpath prefix changes from src to src-generated.

Comment 2 Julian Honnen

2019-03-26 10:51:58 EDT

Created attachment 278016 [details]
plugin to reproduce the issue

Comment 3 Eclipse Genie

2019-03-27 01:48:03 EDT

New Gerrit change created: https://git.eclipse.org/r/139552

Comment 4 Eclipse Genie

2019-03-27 01:51:16 EDT

Gerrit change https://git.eclipse.org/r/139552 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=16c2cb9aaa718e0d66aa427ca0908a0d5f895f7e

Comment 5 Vikas Chandra

2019-04-09 00:26:41 EDT

verified on
Version: 2019-06 (4.12)
Build id: I20190406-1800