Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 545695

Summary:

DOT Editor - Add DOT Attribute support for penwidth=""

Product:

[Tools] GEF

Reporter:

Tamas Miklossy <miklossy>

Component:

GEF DOT

Assignee:

gef-inbox <gef-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

unspecified

Target Milestone:

5.1.0 (2019-06)

Hardware:

OS:

Windows 10

Whiteboard:

Attachments:

Description	Flags
Screenshot displaying the GEF DOT Graph view error message	none

Description Tamas Miklossy

2019-03-23 03:49:54 EDT

Created attachment 277973 [details]
Screenshot displaying the GEF DOT Graph view error message

Rendering the following dot file

https://github.com/eclipse/gef/blob/master/org.eclipse.gef.dot.tests/resources/penwidth.dot

within the DOT Graph view results in the following error message:  Could not import DOT: Cannot set node attribute 'penwidth' to ''. The value '' is not a syntactically correct double: Empty String.

Although this is not documented explicitly, empty penwidth attributes seems to be used/supported by the dot language, especially if the dot file is generated by Graphviz.

Comment 1 Tamas Miklossy

2019-03-23 04:47:49 EDT

I pushed the following changes to the master branch:

[545695] Ensure that the DOT Editor/View accepts empty penwidth values.

- Modify the DotAttributes validateAttributeRawValue method to accept
empty penwidth attribute values (in these cases no validation on the penwidth
attribute value take places at all).
- Implement corresponding DotAttributesTests and DotParserTests test cases.

Resolving as fixed in 5.1.0 (2019-06).