Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 545590

Summary: [12] JRE Oracle Corporation/12 is not supported, advanced source lookup disabled
Product: [Eclipse Project] JDT Reporter: Sarika Sinha <sarika.sinha>
Component: DebugAssignee: Sarika Sinha <sarika.sinha>
Status: VERIFIED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: daniel_megert, igor, mat.booth, rgrunber
Version: 4.11   
Target Milestone: 4.12 M3   
Hardware: PC   
OS: All   
See Also: https://git.eclipse.org/r/141645
https://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=1383301b7d009fb883e0f0139797bb4887ab4580
Whiteboard:
Bug Depends on:    
Bug Blocks: 546235    

Description Sarika Sinha CLA 2019-03-20 11:20:00 EDT 
With Java 12 support Advanced Source lookup is disabled.

Do we need ASM 7.1 ?
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19240
Comment 1 Igor Fedorenko CLA 2019-03-20 11:55:52 EDT 
I never tested advanced sourcelookup with java 12 and didn't feel comfortable to treat that java version as "supported". The max supported version is configured in https://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/tree/org.eclipse.jdt.launching.javaagent/src/main/java/org/eclipse/jdt/launching/internal/weaving/ClassfileTransformer.java#n27 and ASM 7.0 should work with Java 12. Of course, it is probably better to get latest released ASM.
Comment 2 Sarika Sinha CLA 2019-04-03 04:03:29 EDT 
@Mat, any idea about new ASM 7.1 jar adoption ?

We have tets case fialing with Java 12 -
testAvailableStrata	Failure	Wrong number of available strata expected:<2> but was:<1>
Comment 3 Sarika Sinha CLA 2019-04-08 12:01:40 EDT 
changes will happen after ASM 7.1 is available in orbit.
Comment 4 Mat Booth CLA 2019-04-09 10:02:10 EDT 
Adding ASM 7.1 to Orbit is being driven by the Eclemma project, you probably want to follow these CQs:

https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19168
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19240
Comment 5 Sarika Sinha CLA 2019-04-15 03:16:33 EDT 
Orbit build has ASM 7.1 now.
https://download.eclipse.org/tools/orbit/downloads/drops/I20190412225644/
Comment 6 Eclipse Genie CLA 2019-05-06 02:49:26 EDT 
New Gerrit change created: https://git.eclipse.org/r/141645
Comment 8 Sarika Sinha CLA 2019-05-07 02:42:33 EDT 
Works well. Test case also passed
https://download.eclipse.org/eclipse/downloads/drops4/I20190506-1800/testResults.php
Comment 9 Sarika Sinha CLA 2019-05-21 02:40:21 EDT 
Verified using Build id: I20190520-1805.