Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 545194

Summary: [12] Test failures in JDT UI in Y20190307-1015
Product: [Eclipse Project] JDT Reporter: Noopur Gupta <noopur_gupta>
Component: UIAssignee: Noopur Gupta <noopur_gupta>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, jarthana, noopur_gupta, sarika.sinha
Version: 4.11   
Target Milestone: BETA J12   
Hardware: All   
OS: All   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=543720
https://git.eclipse.org/r/138364
https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=a9cbf7787a0c05a7bcd7ca79caa4b8836b5fb35e
https://git.eclipse.org/r/138365
https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=92047b095ca3e89222f3d87c85a42b8a9b213701
Whiteboard:
Bug Depends on: 545201    
Bug Blocks: 545120    

Comment 1 Noopur Gupta CLA 2019-03-08 03:08:41 EST
test28

java.lang.UnsupportedOperationException
at org.eclipse.jdt.core.dom.ASTNode.copySubtree(ASTNode.java:2740)
at org.eclipse.jdt.internal.corext.dom.ASTNodeFactory.newType(ASTNodeFactory.java:210)
at org.eclipse.jdt.internal.corext.dom.ASTNodeFactory.newType(ASTNodeFactory.java:166)
at org.eclipse.jdt.internal.corext.refactoring.code.InlineConstantRefactoring$InlineTargetCompilationUnit.inlineReference(InlineConstantRefactoring.java:539)
at org.eclipse.jdt.internal.corext.refactoring.code.InlineConstantRefactoring$InlineTargetCompilationUnit.getChange(InlineConstantRefactoring.java:499)
at org.eclipse.jdt.internal.corext.refactoring.code.InlineConstantRefactoring.checkFinalConditions(InlineConstantRefactoring.java:843)
at org.eclipse.jdt.ui.tests.refactoring.InlineConstantTests.helper1(InlineConstantTests.java:117)
at org.eclipse.jdt.ui.tests.refactoring.InlineConstantTests.helper1(InlineConstantTests.java:96)
at org.eclipse.jdt.ui.tests.refactoring.InlineConstantTests.test28(InlineConstantTests.java:283)
...
Comment 2 Noopur Gupta CLA 2019-03-08 03:15:22 EST
All others are related to Switch and If in the following suites:

AdvancedQuickAssistTest

AssistQuickFixTest

AdvancedQuickAssistTest17

LocalCorrectionsQuickFixTest

AdvancedQuickAssistTest18
Comment 3 Noopur Gupta CLA 2019-03-08 03:19:28 EST
Need to investigate if changes are required in UI code/tests or these are regressions due to bug 543720.
Comment 4 Noopur Gupta CLA 2019-03-08 03:25:12 EST
(In reply to Noopur Gupta from comment #1)
> test28
This one doesn't fail locally with the latest code. Need to monitor it in the next build.
Comment 5 Noopur Gupta CLA 2019-03-08 03:40:59 EST
(In reply to Noopur Gupta from comment #2)
> All others are related to Switch and If in the following suites:

Initial investigation shows that some of these are because SwitchCase.getExpression() is now deprecated and hence it returns a missing node. I will update the UI code where this method is used and check if the tests pass.
Comment 6 Eclipse Genie CLA 2019-03-08 04:35:28 EST
New Gerrit change created: https://git.eclipse.org/r/138364
Comment 7 Eclipse Genie CLA 2019-03-08 04:35:50 EST
Gerrit change https://git.eclipse.org/r/138364 was merged to [BETA_JAVA_12].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=a9cbf7787a0c05a7bcd7ca79caa4b8836b5fb35e
Comment 8 Noopur Gupta CLA 2019-03-08 04:37:37 EST
(In reply to Eclipse Genie from comment #7)
> Gerrit change https://git.eclipse.org/r/138364 was merged to [BETA_JAVA_12].
> Commit:
> http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=a9cbf7787a0c05a7bcd7ca79caa4b8836b5fb35e
(In reply to Noopur Gupta from comment #2)
> All others are related to Switch and If in the following suites:
> 
> AdvancedQuickAssistTest
> 
> AdvancedQuickAssistTest17
> 
> AdvancedQuickAssistTest18
The above are fixed with the released changes.

> AssistQuickFixTest
> LocalCorrectionsQuickFixTest
Pending.
Comment 9 Eclipse Genie CLA 2019-03-08 04:50:01 EST
New Gerrit change created: https://git.eclipse.org/r/138365
Comment 10 Eclipse Genie CLA 2019-03-08 04:50:05 EST
Gerrit change https://git.eclipse.org/r/138365 was merged to [BETA_JAVA_12].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=92047b095ca3e89222f3d87c85a42b8a9b213701
Comment 11 Noopur Gupta CLA 2019-03-08 04:57:59 EST
(In reply to Eclipse Genie from comment #10)
> Gerrit change https://git.eclipse.org/r/138365 was merged to [BETA_JAVA_12].
> Commit:
> http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=92047b095ca3e89222f3d87c85a42b8a9b213701
(In reply to Noopur Gupta from comment #8)
> > AssistQuickFixTest
> > LocalCorrectionsQuickFixTest
Fixed.
Comment 12 Noopur Gupta CLA 2019-03-08 04:58:51 EST
I will request Jay for a new Y-build to verify the fixes.
Comment 13 Noopur Gupta CLA 2019-03-13 10:38:25 EDT
(In reply to Noopur Gupta from comment #4)
> (In reply to Noopur Gupta from comment #1)
> > test28
> This one doesn't fail locally with the latest code. Need to monitor it in
> the next build.
It failed again in the next Y-build but it is still not failing locally. I will investigate if it fails even after merging to master branch.
Comment 14 Sarika Sinha CLA 2019-03-13 22:36:49 EDT
(In reply to Noopur Gupta from comment #13)
> It failed again in the next Y-build but it is still not failing locally. I
> will investigate if it fails even after merging to master branch.

Can you check in gerrit builds as now they run against Y build?
Comment 15 Noopur Gupta CLA 2019-03-14 11:25:29 EDT
(In reply to Sarika Sinha from comment #14)
> (In reply to Noopur Gupta from comment #13)
> > It failed again in the next Y-build but it is still not failing locally. I
> > will investigate if it fails even after merging to master branch.
> 
> Can you check in gerrit builds as now they run against Y build?
It doesn't work for JDT UI yet.
Comment 16 Noopur Gupta CLA 2019-03-20 07:31:42 EDT
(In reply to Noopur Gupta from comment #13)
> (In reply to Noopur Gupta from comment #4)
> > (In reply to Noopur Gupta from comment #1)
> > > test28
> > This one doesn't fail locally with the latest code. Need to monitor it in
> > the next build.
> It failed again in the next Y-build but it is still not failing locally. I
> will investigate if it fails even after merging to master branch.

It does not fail in BETA branch Gerrit build also but failed in Y20190319-2305 as well. So, probably something wrong in just the Y-build setup.