Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 545061

Summary: Auto-update of supported eclipse version automation does not work for some plugins
Product: Community Reporter: Albert Tregnaghi <albert.tregnaghi>
Component: MarketplaceAssignee: Marketplace Inbox <marketplace-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: dma_k, eric.poirier
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Albert Tregnaghi CLA 2019-03-05 07:29:24 EST
For my own projects the automation of supporting next new eclipse version + info mail to myself by marketplace website works very well!

But for some plugins it does not work. I have seen many now:

For an example:

https://marketplace.eclipse.org/content/angularjs-eclipse
https://marketplace.eclipse.org/content/quickrex

and more

Both of the examples are updated this year, so are still quite active and are also favorites in eclipse community. But they still do only provide until 2018-09!

So plugin-users will be annoyed ...

There seems to be a bug inside the update mechanism. As said before: For my own plugins it works very well. Maybe there is an issue when the plugin was created?
Comment 1 Eric Poirier CLA 2019-03-05 08:20:19 EST
Hi Albert,

The auto-update works only if the plugin supports the latest release of Eclipse IDE. Otherwise, the script will ignore the plugin and won't update it. In both of your example, the plugins are not supporting 2018-12 and therefor, didn't get updated to support 2019-03.

We do this because if the owner of a plugin decides to manually remove the support of the latest release, we won't automatically update the plugin on the next release.

Let me know if you have more questions. 

Thanks.
Comment 2 Albert Tregnaghi CLA 2019-03-06 08:21:50 EST
Hello Eric,

IMHO its extreme important for eclipse as a platform to ensure users got still their favorite plugins.

Normally there are no problems when a eclipse major release comes out - eclipse API is very stable. And if there are any problems it's the problem of the plugin not of the marketplace... So I am not sure if the"supported versions" at marketplace are really the way to go or if not the "new checkboxes/boolean states" should be allways .

But nevertheless the issue is about the current situation...

I am not sure if there was not an overlap in time, means where people did update their solution info in marketplace by their own, were a little bit late and when the automation process started  - so maybe many plugins get out of scope of the update?

Does auto update logic also inform plugin owners where the info will NOT be upated, about that they are not automatically updated on marketplace and that their solution will NOT be found by the new eclipse versions /marketplace clients any longer ?

If they are not informed - you should consider to send mails for this purpose too. Maybe there are owners which are not aware about the problem.


Greez
Albert
Comment 3 Eric Poirier CLA 2019-03-06 09:26:22 EST
(In reply to Albert Tregnaghi from comment #2)
> Hello Eric,
> 
> IMHO its extreme important for eclipse as a platform to ensure users got
> still their favorite plugins.

I agree with you, users should be able to find their plugins in the Eclipse Marketplace if the plugins do support the release users are using.

> 
> Normally there are no problems when a eclipse major release comes out -
> eclipse API is very stable. And if there are any problems it's the problem
> of the plugin not of the marketplace... So I am not sure if the"supported
> versions" at marketplace are really the way to go or if not the "new
> checkboxes/boolean states" should be allways .
> 
> But nevertheless the issue is about the current situation...
> 
> I am not sure if there was not an overlap in time, means where people did
> update their solution info in marketplace by their own, were a little bit
> late and when the automation process started  - so maybe many plugins get
> out of scope of the update?

We had a bug with the script a few months ago which updated plugins that did not support 2018-12 and added support to 2019-03. This issue was fixed and the plugins were updated again to show the correct list of supported releases.

> 
> Does auto update logic also inform plugin owners where the info will NOT be
> upated, about that they are not automatically updated on marketplace and
> that their solution will NOT be found by the new eclipse versions
> /marketplace clients any longer ?

For now an email is sent to plugin owners about their newly updated plugins. If a plugin did not get updated, an email is not being sent.

That being said, we might want to consider sending to all listing owners when a new release is available for them to verify their list of supported releases.

> 
> If they are not informed - you should consider to send mails for this
> purpose too. Maybe there are owners which are not aware about the problem.

Not sure if this is what you meant, but the owners were informed when we discovered the bug in the script that wrongfully updated supported releases in the plugins. We also asked owners to verify and update their plugins if the list of supported releases is incorrect. 

> 
> 
> Greez
> Albert
Comment 4 Albert Tregnaghi CLA 2019-03-13 01:15:30 EDT
(In reply to Eric Poirier from comment #3)
...
> For now an email is sent to plugin owners about their newly updated plugins.
> If a plugin did not get updated, an email is not being sent.
> 
> That being said, we might want to consider sending to all listing owners
> when a new release is available for them to verify their list of supported
> releases.

This above is what I meant - sending mails to users when their plugin is NOT updated.
So at least they got the information to be no longer available at newest marketplace client/eclipse version...

I think this would be nice and ensures enough attention from plugin owners...


Greez Albert
Comment 5 Eric Poirier CLA 2019-04-01 15:37:04 EDT
Hi Albert,

A patch has been merged today so when we update the Solutions again for a new Eclipse Release, we will also notify owners that their Solution did not get updated to support the latest release and to ask them to make the appropriate changes if needed.

Please reopen this bug if there's an issue with the change.

Thanks.
Comment 6 Albert Tregnaghi CLA 2019-04-02 02:32:28 EDT
Sounds good

Thank you